feat(aeb): set global param to override autoware state check #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Sanchez <[email protected]>
danielsanchezaran
requested review from
yukkysaito and
mitsudome-r
as code owners
1 task
Signed-off-by: Daniel Sanchez <[email protected]>
Signed-off-by: Daniel Sanchez <[email protected]>
takayuki5168
approved these changes
Nov 8, 2024
Signed-off-by: Daniel Sanchez <[email protected]>
danielsanchezaran
requested review from
rej55,
satoshi-ota,
shmpwk,
kyoichi-sugahara,
zulfaqar-azmi-t4,
go-sakayori,
kosuke55,
mkquda,
maxime-clem,
soblin and
yhisaki
as code owners
github-actions
bot
added
the
component:control
Signed-off-by: Daniel Sanchez <[email protected]>
danielsanchezaran
deleted the
feat/awf-set-global-param-for-aeb-state-check
branch
danielsanchezaran
added a commit
to tier4/autoware_launch
that referenced
this pull request
Nov 15, 2024
…efoundation#1218) * set global param to override autoware state check Signed-off-by: Daniel Sanchez <[email protected]> * change variable for a more generic name Signed-off-by: Daniel Sanchez <[email protected]> * set var to false by default Signed-off-by: Daniel Sanchez <[email protected]> * move param to control component launch Signed-off-by: Daniel Sanchez <[email protected]> * change param name to be more straightforward Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
danielsanchezaran
added a commit
to tier4/autoware_launch
that referenced
this pull request
Nov 15, 2024
…sable-aeb-state-check feat(aeb): set global param to override autoware state check (autowarefoundation#1218)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a parameter to set AEB's state check to true or false in the launch file, this changes is aimed at facilitating ci/cd evaluation where turning this parameter on and off is sometimes necessary depending on the evaluation tool (DLR, planning simulation, etc).
Example usage:
ros2 launch autoware_launch logging_simulator.launch.xml map_path:=$HOME/autoware_map/lane_change_map vehicle_model:=lexus sensor_model:=aip_xx1 use_aeb_autoware_state_check:=falseNote, requires universe changes: autowarefoundation/autoware.universe#9263
Tests performed
PSim
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.