Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware.repos): remove autoware_auto_msgs #5011

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jul 18, 2024

Description

This PR is to remove autoware_auto_msgs completely from Autoware.

Autoware still doesn't build with this repository removed because:

Still depend on it.

Tests performed

Perform a clean build with this repository removed.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx requested a review from mitsudome-r July 18, 2024 13:59
@xmfcx xmfcx self-assigned this Jul 18, 2024
@xmfcx xmfcx added the tag:run-health-check Run health-check label Jul 18, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Jul 18, 2024

Created this PR:

And temporarily pointing to that to check if it all compiles and passes the tests.

@xmfcx xmfcx requested a review from isamu-takagi July 18, 2024 21:35
@xmfcx
Copy link
Contributor Author

xmfcx commented Jul 18, 2024

tier4/tier4_ad_api_adaptor#122 (review)

These APIs define the output type as auto_msgs in their specifications, so it cannot be changed. Currently, all APIs other than the RTC API are deprecated, so I'm considering removing the reference to this repository.

@isamu-takagi san, could you take over this PR then?

@isamu-takagi isamu-takagi self-assigned this Jul 18, 2024
@xmfcx xmfcx removed their assignment Jul 18, 2024
@xmfcx xmfcx removed the request for review from isamu-takagi July 18, 2024 21:55
Signed-off-by: Takagi, Isamu <[email protected]>
@isamu-takagi
Copy link
Contributor

Instead of removing the entire repository, remove the API related to autoware_auto_msgs. tier4/tier4_ad_api_adaptor#124

@isamu-takagi isamu-takagi marked this pull request as ready for review August 7, 2024 01:28
@isamu-takagi
Copy link
Contributor

This PR should be merged after tier4/tier4_ad_api_adaptor#124.

Signed-off-by: Takagi, Isamu <[email protected]>
@isamu-takagi isamu-takagi merged commit 2f9cbfb into main Aug 7, 2024
15 checks passed
@isamu-takagi isamu-takagi deleted the feat/rm-autoware-auto-msgs branch August 7, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants