-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware.repos): remove autoware_auto_msgs #5011
Conversation
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Created this PR: And temporarily pointing to that to check if it all compiles and passes the tests. |
tier4/tier4_ad_api_adaptor#122 (review)
@isamu-takagi san, could you take over this PR then? |
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Instead of removing the entire repository, remove the API related to autoware_auto_msgs. tier4/tier4_ad_api_adaptor#124 |
This PR should be merged after tier4/tier4_ad_api_adaptor#124. |
Signed-off-by: Takagi, Isamu <[email protected]>
Description
This PR is to remove
autoware_auto_msgs
completely from Autoware.Autoware still doesn't build with this repository removed because:
Still depend on it.
Tests performed
Perform a clean build with this repository removed.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.