Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware.repos): update TODO comment #5463

Merged
merged 2 commits into from
Nov 21, 2024
Merged

chore(autoware.repos): update TODO comment #5463

merged 2 commits into from
Nov 21, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Nov 20, 2024

Description

This PR removes the TODO comment written in #5011. There is no longer any dependency on autoware_auto_msgs by tier4/tier4_ad_api_adaptor#124.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk self-assigned this Nov 20, 2024
@youtalk youtalk added the component:interfaces Communication protocols, interfaces and messages. label Nov 20, 2024
@youtalk youtalk requested a review from xmfcx November 20, 2024 13:30
@youtalk youtalk marked this pull request as ready for review November 20, 2024 13:30
@youtalk youtalk requested a review from mitsudome-r as a code owner November 20, 2024 13:30
@youtalk youtalk added the tag:run-health-check Run health-check label Nov 20, 2024
@xmfcx xmfcx requested a review from isamu-takagi November 20, 2024 13:32
autoware.repos Outdated Show resolved Hide resolved
@xmfcx
Copy link
Contributor

xmfcx commented Nov 20, 2024

History:

@yukkysaito said:

But almost all API in tier4_ad_api_adaptor should be defined Autoware interface by AWF in near future. Then remove tier4_ and move to AWF repository.

(Older PR/issues are in archived https://github.com/autowarefoundation/autoware_core_universe_prototype repository)

@youtalk youtalk changed the title chore(autoware.repos): remove TODO comment chore(autoware.repos): update TODO comment Nov 20, 2024
@youtalk
Copy link
Member Author

youtalk commented Nov 20, 2024

@xmfcx Thank you for the explanation. I've changed the title too.

Co-authored-by: M. Fatih Cırıt <[email protected]>
@youtalk youtalk requested a review from xmfcx November 21, 2024 00:37
@youtalk youtalk enabled auto-merge (squash) November 21, 2024 00:40
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@youtalk youtalk merged commit 6a284d0 into main Nov 21, 2024
17 of 18 checks passed
@youtalk youtalk deleted the remove-todo branch November 21, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:interfaces Communication protocols, interfaces and messages. tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants