Skip to content

fix(goal_planner): fix detection_polygons visualiztion

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Nov 15, 2023 in 54s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) βœ…
  • Affected Hotspots: 1 files(s) πŸ”₯

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method goal_planner_module.cpp: GoalPlannerModule::setDebugData πŸ”₯

Annotations

Check notice on line 1 in planning/behavior_path_planner/src/scene_module/goal_planner/goal_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

β„Ή Getting worse: Lines of Code in a Single File

The lines of code increases from 1368 to 1369, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check warning on line 1764 in planning/behavior_path_planner/src/scene_module/goal_planner/goal_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

GoalPlannerModule::setDebugData already has high cyclomatic complexity, and now it increases in Lines of Code from 114 to 115. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.