Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the PR template #7667

Merged
merged 6 commits into from
Jun 24, 2024
Merged

chore: update the PR template #7667

merged 6 commits into from
Jun 24, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jun 24, 2024

Description

Old PR pipeline:

  • Click on the preview button (Unintuitive)
  • Select a PR template
  • There are many checkboxes (nobody uses them and things get merged anyways)

Old method:

2024-06-24.16-14-10.mp4

New PR pipeline:

  • Template comes right away, has the best of both templates in a single simple package.
    • Multi-line comments are color coded, easy to remove.
  • Checkboxes are removed and offloaded to a CI action to comment automatically on the PR.
  • Verbose/obvious comments are removed, it is very clean now.
  • Test new template using this link
  • Renamed the PULL_REQUEST_TEMPLATE.md to pull_request_template.md following Github's Creating a pull request template for your repository guidelines

Tests performed

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx xmfcx self-assigned this Jun 24, 2024
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jun 24, 2024
Copy link

github-actions bot commented Jun 24, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

pre-commit-ci bot and others added 2 commits June 24, 2024 13:15
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 24, 2024
@xmfcx xmfcx requested review from yukkysaito and mitsudome-r June 24, 2024 13:25
@xmfcx xmfcx marked this pull request as ready for review June 24, 2024 13:26
M. Fatih Cırıt added 3 commits June 24, 2024 16:31
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx xmfcx merged commit ef3cef1 into main Jun 24, 2024
25 checks passed
@xmfcx xmfcx deleted the feat/update-pr-template-and-ci branch June 24, 2024 15:03
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: Simon Eisenmann <[email protected]>
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants