Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(comment-on-pr): make it work on forks #7680

Merged
merged 1 commit into from
Jun 25, 2024
Merged

ci(comment-on-pr): make it work on forks #7680

merged 1 commit into from
Jun 25, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jun 25, 2024

Description

It failed on this fork pr:

Now changing the trigger to pull_request_target so it can access repo's github token for commenting.

Also changing the general naming to fit the repo's other workflows. Shouldn't affect anything since I've added this new workflow just yesterday.

Related links

Follow up from:

Related solution:

How was this PR tested?

  • Can't be tested within this repo until it is merged (because pull_request_target trigger runs on the repo commit version).
  • Could be tested on a separate repo but I didn't since it is simple.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jun 25, 2024
@xmfcx xmfcx requested a review from mitsudome-r June 25, 2024 06:46
@xmfcx xmfcx self-assigned this Jun 25, 2024
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 25, 2024
@xmfcx xmfcx merged commit 7685d8a into main Jun 25, 2024
36 checks passed
@xmfcx xmfcx deleted the ci/comment-on-pr-fork branch June 25, 2024 06:55
@xmfcx
Copy link
Contributor Author

xmfcx commented Jun 25, 2024

simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: Simon Eisenmann <[email protected]>
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant