Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pull request template #91

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Oct 31, 2024

Description

This makes the same modification we made to Autoware.Universe in autowarefoundation/autoware.universe#7667.

Related links

#88
autowarefoundation/autoware.universe#7667

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mitsudome-r mitsudome-r requested review from youtalk and xmfcx November 6, 2024 03:46
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked them on autoware.universe. They look the same.
https://github.com/autowarefoundation/autoware.universe/tree/main/.github

@mitsudome-r mitsudome-r merged commit c9327b9 into autowarefoundation:main Nov 7, 2024
16 of 17 checks passed
@mitsudome-r mitsudome-r deleted the chore/update-pull-request-template branch November 7, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants