Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware_behavior_velocity_planner): remove no_prefix function from tests #7589

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jun 19, 2024

Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 19, 2024
@esteve
Copy link
Contributor Author

esteve commented Jun 19, 2024

This PR will be ready for review once all the other PRs for autoware_behavior_velocity_planner are merged (#7469 #7467)

@esteve esteve force-pushed the remove-no_prefix branch from b984dd4 to fd98c19 Compare July 2, 2024 12:16
@esteve esteve enabled auto-merge (squash) July 2, 2024 12:16
Copy link

github-actions bot commented Jul 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve
Copy link
Contributor Author

esteve commented Jul 2, 2024

This PR now just removes a comment that no longer applies, since the _no_prefix function was already deleted before.

@esteve
Copy link
Contributor Author

esteve commented Jul 2, 2024

@satoshi-ota @shmpwk could you approve this PR when you have a moment? The only change is that a comment is deleted. Thanks.

@shmpwk shmpwk added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.36%. Comparing base (ce09907) to head (fd98c19).
Report is 92 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7589      +/-   ##
==========================================
- Coverage   28.37%   28.36%   -0.02%     
==========================================
  Files        1584     1589       +5     
  Lines      115596   115650      +54     
  Branches    49279    49279              
==========================================
+ Hits        32799    32800       +1     
- Misses      73849    73902      +53     
  Partials     8948     8948              
Flag Coverage Δ *Carryforward flag
differential 13.33% <ø> (?)
total 28.37% <ø> (ø) Carriedforward from ce09907

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve merged commit 458dbe5 into autowarefoundation:main Jul 9, 2024
38 of 39 checks passed
@esteve esteve deleted the remove-no_prefix branch July 9, 2024 05:45
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants