Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lidar_centerpoint_tvm): fix constVariable warnings #7546

Closed

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jun 18, 2024

Description

This is a fix based on cppcheck constVariable warnings

perception/lidar_centerpoint_tvm/lib/preprocess/generate_features.cpp:45:13: style: Variable 'coordinate' can be declared as const array [constVariable]
    int32_t coordinate[3] = {
            ^
perception/lidar_centerpoint_tvm/lib/preprocess/generate_features.cpp:61:11: style: Variable 'mean' can be declared as const array [constVariable]
    float mean[3] = {
          ^

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 18, 2024
@knzo25
Copy link
Contributor

knzo25 commented Jun 18, 2024

@veqcc
We are currently evaluating how to proceed with this package, so please wait a little bit 🙏

@veqcc
Copy link
Contributor Author

veqcc commented Jun 26, 2024

@knzo25
Hi, is there any conclusion what to do for this module?

Currently I am working on cpcheck CI workflow to reduce warnings in autoware.universe.
The warning constVariable occurs only in this package. If we solve it, we can make this warning never happens in whole autoware.universe by makeing it requirement.

If it will take more time to make decisions on this module, could you merge this PR?
I believe this change doesn't affect the functionality. Thank you

@knzo25
Copy link
Contributor

knzo25 commented Jun 26, 2024

@veqcc
Right now there is a discussion in the awf to deprecate tvm nodes, but yes, it will take a while.
I agree that we should merge your PR in the meanwhile, but I can not merge this since I am not a maintainer !

@kminoda @YoshiRi
Does either of you have force merge permissions here? 🙏

@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 26, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (507e3f4) to head (d9959a6).
Report is 143 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7546       +/-   ##
==========================================
- Coverage   14.84%   0.00%   -14.85%     
==========================================
  Files        1999      47     -1952     
  Lines      139163    2415   -136748     
  Branches    43716     154    -43562     
==========================================
- Hits        20661       0    -20661     
+ Misses      95731    2415    -93316     
+ Partials    22771       0    -22771     
Flag Coverage Δ
differential 0.00% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knzo25
Copy link
Contributor

knzo25 commented Jun 26, 2024

Just in case, I will leave the discussion here:
https://github.com/orgs/autowarefoundation/discussions/4883#discussioncomment-9876908

@kminoda
Copy link
Contributor

kminoda commented Jun 26, 2024

@knzo25 I think we've waited enough after https://github.com/orgs/autowarefoundation/discussions/4883 has been posted, so let's remove this pacakge.

@veqcc Thank you for the fix, but let us close this PR as this package will be deprecated in a meantime.

@veqcc
Copy link
Contributor Author

veqcc commented Jun 26, 2024

@veqcc Thank you for the fix, but let us close this PR as this package will be deprecated in a meantime.

Okey 👍

@veqcc veqcc closed this Jun 30, 2024
@veqcc veqcc deleted the fix_const_variable_warning branch June 30, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants