-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lidar_centerpoint_tvm): fix constVariable warnings #7546
Conversation
Signed-off-by: Ryuta Kambe <[email protected]>
@veqcc |
@knzo25 Currently I am working on cpcheck CI workflow to reduce warnings in autoware.universe. If it will take more time to make decisions on this module, could you merge this PR? |
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7546 +/- ##
==========================================
- Coverage 14.84% 0.00% -14.85%
==========================================
Files 1999 47 -1952
Lines 139163 2415 -136748
Branches 43716 154 -43562
==========================================
- Hits 20661 0 -20661
+ Misses 95731 2415 -93316
+ Partials 22771 0 -22771
☔ View full report in Codecov by Sentry. |
Just in case, I will leave the discussion here: |
@knzo25 I think we've waited enough after https://github.com/orgs/autowarefoundation/discussions/4883 has been posted, so let's remove this pacakge. @veqcc Thank you for the fix, but let us close this PR as this package will be deprecated in a meantime. |
Okey 👍 |
Description
This is a fix based on cppcheck
constVariable
warningsTests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.