chore(tier4_perception_launch): perception launcher refactoring second round #7440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:launch
4 tasks
technolojin
force-pushed
the
chore/perception-launcher-refactoring2
branch
from
368e644 to
9d723c3
Compare
technolojin
force-pushed
the
chore/perception-launcher-refactoring2
branch
from
6234f40 to
ba922b0
Compare
technolojin
added
the
tag:run-build-and-test-differential
technolojin
force-pushed
the
chore/perception-launcher-refactoring2
branch
from
d30d260 to
c391ab7
Compare
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
This reverts commit 9d723c3. Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
…h.xml Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
technolojin
force-pushed
the
chore/perception-launcher-refactoring2
branch
from
5dcf603 to
64ad0a0
Compare
YoshiRi
approved these changes
Jun 20, 2024
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
…d round (autowarefoundation#7440) * feat: separate filters Signed-off-by: Taekjin LEE <[email protected]> * fix: object validator to modular Signed-off-by: Taekjin LEE <[email protected]> * chore: remove default values from subsequent launch files Signed-off-by: Taekjin LEE <[email protected]> * chore: group interfaces and junctions Signed-off-by: Taekjin LEE <[email protected]> * Revert "chore: group interfaces and junctions" This reverts commit 9d723c3. Signed-off-by: Taekjin LEE <[email protected]> * chore: group interfaces and junctions Signed-off-by: Taekjin LEE <[email protected]> * fix: radar input Signed-off-by: Taekjin LEE <[email protected]> * fix: remove defaults from camera inputs Signed-off-by: Taekjin LEE <[email protected]> * chore: rename camera args Signed-off-by: Taekjin LEE <[email protected]> * chore: reorder Signed-off-by: Taekjin LEE <[email protected]> * fix: remove defaults from lidar interface Signed-off-by: Taekjin LEE <[email protected]> * Add use_pointcloud_map and use_validator arguments to detection.launch.xml Signed-off-by: Taekjin LEE <[email protected]> * fix: remove default from validators and filters Signed-off-by: Taekjin LEE <[email protected]> * fix: pointcloud container node name Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * Add use_low_intensity_cluster_filter argument to launch files Signed-off-by: Taekjin LEE <[email protected]> * fix: on off detector and merger Signed-off-by: Taekjin LEE <[email protected]> * fix: radar_far/objects default Signed-off-by: Taekjin LEE <[email protected]> * fix: radar object filter parameter Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Simon Eisenmann <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…d round (#7440) * feat: separate filters Signed-off-by: Taekjin LEE <[email protected]> * fix: object validator to modular Signed-off-by: Taekjin LEE <[email protected]> * chore: remove default values from subsequent launch files Signed-off-by: Taekjin LEE <[email protected]> * chore: group interfaces and junctions Signed-off-by: Taekjin LEE <[email protected]> * Revert "chore: group interfaces and junctions" This reverts commit 9d723c3. Signed-off-by: Taekjin LEE <[email protected]> * chore: group interfaces and junctions Signed-off-by: Taekjin LEE <[email protected]> * fix: radar input Signed-off-by: Taekjin LEE <[email protected]> * fix: remove defaults from camera inputs Signed-off-by: Taekjin LEE <[email protected]> * chore: rename camera args Signed-off-by: Taekjin LEE <[email protected]> * chore: reorder Signed-off-by: Taekjin LEE <[email protected]> * fix: remove defaults from lidar interface Signed-off-by: Taekjin LEE <[email protected]> * Add use_pointcloud_map and use_validator arguments to detection.launch.xml Signed-off-by: Taekjin LEE <[email protected]> * fix: remove default from validators and filters Signed-off-by: Taekjin LEE <[email protected]> * fix: pointcloud container node name Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * Add use_low_intensity_cluster_filter argument to launch files Signed-off-by: Taekjin LEE <[email protected]> * fix: on off detector and merger Signed-off-by: Taekjin LEE <[email protected]> * fix: radar_far/objects default Signed-off-by: Taekjin LEE <[email protected]> * fix: radar object filter parameter Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove default value scattered in subsequent launch files.
Continuous work of #7194
Tests performed
Tested in a local recompute environment. Variants were covered manually.
Effects on system behavior
Not applicable.
Interface changes
The refactoring was done within the perception pipeline. The behavior has not been changed.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.