-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_velocity_planner_common)!: prefix package and namespace with autoware #7314
Merged
shmpwk
merged 4 commits into
autowarefoundation:main
from
rej55:refactor/prefix_package_behavior_velocity_planner_common
Jun 7, 2024
Merged
refactor(behavior_velocity_planner_common)!: prefix package and namespace with autoware #7314
shmpwk
merged 4 commits into
autowarefoundation:main
from
rej55:refactor/prefix_package_behavior_velocity_planner_common
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rej55
force-pushed
the
refactor/prefix_package_behavior_velocity_planner_common
branch
2 times, most recently
from
June 6, 2024 09:49
7e7fb6f
to
dc19c28
Compare
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
labels
Jun 6, 2024
Signed-off-by: Fumiya Watanabe <[email protected]>
Signed-off-by: Fumiya Watanabe <[email protected]>
…_velocity_walkway_module Signed-off-by: Fumiya Watanabe <[email protected]>
Signed-off-by: Fumiya Watanabe <[email protected]>
rej55
force-pushed
the
refactor/prefix_package_behavior_velocity_planner_common
branch
from
June 7, 2024 05:59
dc19c28
to
97c8ec8
Compare
rej55
changed the title
refactor(behavior_velocity_planner_common): add autoware prefix
refactor(behavior_velocity_planner_common): prefix package and namespace with autoware
Jun 7, 2024
rej55
changed the title
refactor(behavior_velocity_planner_common): prefix package and namespace with autoware
refactor(behavior_velocity_planner_common)!: prefix package and namespace with autoware
Jun 7, 2024
rej55
requested review from
maxime-clem,
soblin,
satoshi-ota,
shmpwk,
tkimura4,
mehmetdogru,
isamu-takagi,
takayuki5168,
taikitanaka3,
kosuke55,
ahmeddesokyebrahim,
TakaHoribe,
kyoichi-sugahara,
yuki-takagi-66 and
danielsanchezaran
as code owners
June 7, 2024 06:07
rej55
requested review from
mkuri,
TomohitoAndo and
zulfaqar-azmi-t4
as code owners
June 7, 2024 06:07
satoshi-ota
approved these changes
Jun 7, 2024
yuki-takagi-66
approved these changes
Jun 7, 2024
TomohitoAndo
approved these changes
Jun 7, 2024
soblin
approved these changes
Jun 7, 2024
rej55
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jun 7, 2024
shmpwk
approved these changes
Jun 7, 2024
maxime-clem
approved these changes
Jun 7, 2024
danielsanchezaran
approved these changes
Jun 7, 2024
kosuke55
approved these changes
Jun 7, 2024
rej55
deleted the
refactor/prefix_package_behavior_velocity_planner_common
branch
June 7, 2024 07:20
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…pace with autoware (#7314) * refactor(behavior_velocity_planner_common): add autoware prefix Signed-off-by: Fumiya Watanabe <[email protected]> * refactor(behavior_velocity_planner_common): fix run_out module Signed-off-by: Fumiya Watanabe <[email protected]> * refactor(behavior_velocity_planner_common): fix for autoware_behavior_velocity_walkway_module Signed-off-by: Fumiya Watanabe <[email protected]> * refactor(behavior_velocity_planner_common): remove unnecessary using Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
autoware_
prefix tobehavior_velocity_planner_common
.In addition, I add the
autoware_
prefix to namespace inbehavior_velocity_**
packages.Related links
Part of:
Tests performed
Tested in planning_simulator
Notes for reviewers
Interface changes
Not applicable.
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.