Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_perception_launch): add object_merger of far_objects to fusion for Camera-LiDAR-Radar fusion #4995

Closed

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Sep 14, 2023

Description

This PR add object_merger of far_objects to fusion for Camera-LiDAR-Radar fusion and refactor according to it.

  • Add object_merger of far_objects in launch/object_recognition/detection/camera_lidar_radar_fusion_based_detection.launch.xml

Until the tracking merger can operate stably, this PR temporarily added near_object and far_object mergers to the detection side and connected the far detection pipeline to tracking.
near_object come from existing Camera-LiDAR-Radar fusion and far_object come from radar detection.

  • Add radar lanelets filter parameter to detection launch

I added radar lanelets filter parameter to detection launch to use config parameter from autoware.launch

  • Refactor parameter name and comment

To make it easier to understand parameters, I renamed parameter names and comment.

Related links

Tests performed

Tests by rosbag.

Screenshot from 2023-09-14 17-20-34

Red objects are detection/radar/far_object.
Other objects are tracking/objects.
Grid size is 10m.
I could confirm that the long-distance detection was working properly with tracking.

Notes for reviewers

Interface changes

None

Effects on system behavior

As adding faraway detection, dynamic objects at a distance become visible, so it effects to planning behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ion for Camera-LiDAR-Radar fusion

Signed-off-by: scepter914 <[email protected]>
Signed-off-by: scepter914 <[email protected]>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Sep 14, 2023
@scepter914 scepter914 changed the title fix(tier4_perception_launch): Add object_merger of far_objects to fusion for Camera-LiDAR-Radar fusion fix(tier4_perception_launch): add object_merger of far_objects to fusion for Camera-LiDAR-Radar fusion Sep 14, 2023
@scepter914 scepter914 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 14, 2023
scepter914 and others added 3 commits September 14, 2023 18:29
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ea9d4b0) 15.74% compared to head (b24fb3b) 15.75%.
Report is 8 commits behind head on main.

❗ Current head b24fb3b differs from pull request most recent head 635f656. Consider uploading reports for the commit 635f656 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4995    +/-   ##
========================================
  Coverage   15.74%   15.75%            
========================================
  Files        1587     1587            
  Lines      109831   109654   -177     
  Branches    33719    33636    -83     
========================================
- Hits        17292    17274    -18     
+ Misses      73908    73785   -123     
+ Partials    18631    18595    -36     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 15.75% <ø> (+<0.01%) ⬆️ Carriedforward from fffd994

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
..._safety_checker/path_safety_checker_parameters.hpp 50.00% <ø> (+16.66%) ⬆️
.../scene_module/goal_planner/goal_planner_module.cpp 8.48% <ø> (-0.02%) ⬇️
..._planner/src/scene_module/goal_planner/manager.cpp 5.48% <ø> (-0.08%) ⬇️
...planner/src/scene_module/start_planner/manager.cpp 4.60% <ø> (-0.26%) ⬇️
...cene_module/start_planner/start_planner_module.cpp 29.96% <ø> (+0.10%) ⬆️
...rc/utils/path_safety_checker/objects_filtering.cpp 22.75% <ø> (-0.90%) ⬇️
...nner/src/utils/start_goal_planner_common/utils.cpp 52.30% <ø> (-0.73%) ⬇️

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: scepter914 <[email protected]>
scepter914 and others added 7 commits September 19, 2023 12:09
…tion/lidar_radar_based_detection.launch.xml

Co-authored-by: Shunsuke Miura <[email protected]>
Signed-off-by: scepter914 <[email protected]>
Signed-off-by: scepter914 <[email protected]>
…th from avoidance module (autowarefoundation#5015)

* update function of create predicted path

Signed-off-by: kyoichi-sugahara <[email protected]>

* util common function of create predicted path from avoidance module

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: scepter914 <[email protected]>
…tion#5018)

* refactor(avoidance): generate drivable lanes in utils

Signed-off-by: satoshi-ota <[email protected]>

* refactor(avoidance): use std::any_of

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 19, 2023
Signed-off-by: scepter914 <[email protected]>
@github-actions github-actions bot removed component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 19, 2023
@scepter914
Copy link
Contributor Author

When merge from main branch, conflicts has occurred because new PR is merged to main branch.
So I fixed it, but I could not fix DCO problem.
I'm sorry that I will make PR again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants