-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tier4_perception_launch): add object_merger of far_objects to fusion for Camera-LiDAR-Radar fusion #4995
fix(tier4_perception_launch): add object_merger of far_objects to fusion for Camera-LiDAR-Radar fusion #4995
Conversation
…ion for Camera-LiDAR-Radar fusion Signed-off-by: scepter914 <[email protected]>
Signed-off-by: scepter914 <[email protected]>
Signed-off-by: scepter914 <[email protected]>
Signed-off-by: scepter914 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4995 +/- ##
========================================
Coverage 15.74% 15.75%
========================================
Files 1587 1587
Lines 109831 109654 -177
Branches 33719 33636 -83
========================================
- Hits 17292 17274 -18
+ Misses 73908 73785 -123
+ Partials 18631 18595 -36
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: scepter914 <[email protected]>
…ware.universe into feat/merge_far_detection
...perception_launch/launch/object_recognition/detection/lidar_radar_based_detection.launch.xml
Show resolved
Hide resolved
...perception_launch/launch/object_recognition/detection/lidar_radar_based_detection.launch.xml
Outdated
Show resolved
Hide resolved
…tion/lidar_radar_based_detection.launch.xml Co-authored-by: Shunsuke Miura <[email protected]> Signed-off-by: scepter914 <[email protected]>
Signed-off-by: scepter914 <[email protected]>
…th from avoidance module (autowarefoundation#5015) * update function of create predicted path Signed-off-by: kyoichi-sugahara <[email protected]> * util common function of create predicted path from avoidance module Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: scepter914 <[email protected]>
…Path from lane_change (autowarefoundation#5013)
) Signed-off-by: kosuke55 <[email protected]> Co-authored-by: kminoda <[email protected]>
…tion#5018) * refactor(avoidance): generate drivable lanes in utils Signed-off-by: satoshi-ota <[email protected]> * refactor(avoidance): use std::any_of Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6be86f9
to
74865f0
Compare
Signed-off-by: scepter914 <[email protected]>
When merge from main branch, conflicts has occurred because new PR is merged to main branch. |
Description
This PR add
object_merger
of far_objects to fusion for Camera-LiDAR-Radar fusion and refactor according to it.Until the tracking merger can operate stably, this PR temporarily added near_object and far_object mergers to the detection side and connected the far detection pipeline to tracking.
near_object
come from existing Camera-LiDAR-Radar fusion andfar_object
come from radar detection.I added radar lanelets filter parameter to detection launch to use config parameter from autoware.launch
To make it easier to understand parameters, I renamed parameter names and comment.
Related links
Tests performed
Tests by rosbag.
Red objects are detection/radar/far_object.
Other objects are tracking/objects.
Grid size is 10m.
I could confirm that the long-distance detection was working properly with tracking.
Notes for reviewers
Interface changes
None
Effects on system behavior
As adding faraway detection, dynamic objects at a distance become visible, so it effects to planning behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.