Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rerouting-static-obstacle): rerouting static obstacle using a selected point by the user #4524

Closed
wants to merge 24 commits into from

style(pre-commit): autofix

aca5be2
Select commit
Loading
Failed to load commit list.
Closed

feat(rerouting-static-obstacle): rerouting static obstacle using a selected point by the user #4524

style(pre-commit): autofix
aca5be2
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Mar 14, 2024 in 1m 2s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional rerouting_static_obstacle.cpp: ReroutingStaticObstacle::search_alternative_route

Annotations

Check warning on line 166 in planning/mission_planner/src/rerouting_static_obstacle/rerouting_static_obstacle.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional 

ReroutingStaticObstacle::search_alternative_route has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
View more details on CodeScene Delta Analysis