Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rerouting-static-obstacle): rerouting static obstacle using a selected point by the user #4524

Conversation

ahmeddesokyebrahim
Copy link
Contributor

@ahmeddesokyebrahim ahmeddesokyebrahim commented Aug 5, 2023

Description

closes #4523

Related links

Discussion / Idea
Issue

Tests performed

Using planning simulator :

  • add the RerouteStaticObstaclePointPublish plugin using the add plugin sign , then under rviz under tier4_planning_rviz_plugin --> RerouteStaticObstaclePointPublish.
  • make the plugin visible for ease of use
  • select a point through the route of the vehicle
  • if alternative route is available, vehicle should be able to change route and does not go through the selected point.

This video demo shows the testing procedure.

Notes for reviewers

  • Please follow the same procedure as show in the video above for testing

Interface changes

N.A.

Effects on system behavior

Autoware will be able to reroute for road blockage based on input from the user (human driver/operator)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Summary by CodeRabbit

Release Notes:

  • New Feature: Added a feature for rerouting static obstacles based on user-selected points in the tier4_planning_rviz_plugin package.
  • New Feature: Included a new launch file and component (rerouting_static_obstacle_component) in the mission_planner project for rerouting static obstacles.
  • Dependency Update: Added autoware_auto_mapping_msgs as a dependency in the mission_planner package.

"A path rerouted, obstacles overcome,
With clicks and points, a journey begun.
Autoware's power, now enhanced anew,
Rerouting static obstacles, it can do!"

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Aug 5, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim self-assigned this Aug 5, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 5, 2023
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Attention: Patch coverage is 0% with 141 lines in your changes are missing coverage. Please review.

Project coverage is 14.77%. Comparing base (6ee9627) to head (aca5be2).

Files Patch % Lines
...ting_static_obstacle/rerouting_static_obstacle.cpp 0.00% 86 Missing ⚠️
...static_obstacle/reroute_static_obstacle_plugin.cpp 0.00% 55 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4524      +/-   ##
==========================================
- Coverage   14.79%   14.77%   -0.02%     
==========================================
  Files        1920     1922       +2     
  Lines      132398   132539     +141     
  Branches    39345    39345              
==========================================
  Hits        19582    19582              
- Misses      90970    91111     +141     
  Partials    21846    21846              
Flag Coverage Δ *Carryforward flag
differential 7.11% <0.00%> (?)
total 14.79% <ø> (ø) Carriedforward from 6ee9627

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/universe/4523-rerouting-static-obstacle branch 2 times, most recently from eeb3dcb to f673ae2 Compare August 7, 2023 11:40
@ahmeddesokyebrahim ahmeddesokyebrahim added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Aug 7, 2023
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Aug 10, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/universe/4523-rerouting-static-obstacle branch from b1d1c8e to 0dd2b5a Compare August 10, 2023 15:20
@ahmeddesokyebrahim ahmeddesokyebrahim marked this pull request as ready for review August 10, 2023 16:20
@ahmeddesokyebrahim ahmeddesokyebrahim marked this pull request as draft February 29, 2024 15:06
@xmfcx
Copy link
Contributor

xmfcx commented Mar 5, 2024

@ahmeddesokyebrahim could you resolve the conflicts for this PR?

@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/universe/4523-rerouting-static-obstacle branch 2 times, most recently from 3cb712c to 7cad7dd Compare March 8, 2024 23:05
ahmeddesokyebrahim and others added 24 commits March 14, 2024 16:34
…ic obstacle based on point publisher by the user

Signed-off-by: AhmedEbrahim <[email protected]>
…rerouting point by the user

Signed-off-by: AhmedEbrahim <[email protected]>
…tion for rerouting in readme file

Signed-off-by: AhmedEbrahim <[email protected]>
…ed point as point instead of pose

Signed-off-by: AhmedEbrahim <[email protected]>
… being outdated for very long time.

Signed-off-by: AhmedEbrahim <[email protected]>
…nges for changing and setting route

NOTE : this is still wip and the functionality is not yet finished after this change.
Signed-off-by: AhmedEbrahim <[email protected]>

feat(reroute-static-obstacle): fixing compilation issue after api changes for changing and setting route

NOTE : this is still wip and the functionality is not yet finished after this change.

Signed-off-by: AhmedEbrahim <[email protected]>
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/universe/4523-rerouting-static-obstacle branch from 943d0a1 to aca5be2 Compare March 14, 2024 14:35
@xmfcx xmfcx closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rerouting static obstacle using a selected point by the user
6 participants