-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rerouting-static-obstacle): rerouting static obstacle using a selected point by the user #4524
Closed
ahmeddesokyebrahim
wants to merge
24
commits into
autowarefoundation:main
from
ahmeddesokyebrahim:autoware/universe/4523-rerouting-static-obstacle
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
labels
Aug 5, 2023
ahmeddesokyebrahim
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Aug 5, 2023
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4524 +/- ##
==========================================
- Coverage 14.79% 14.77% -0.02%
==========================================
Files 1920 1922 +2
Lines 132398 132539 +141
Branches 39345 39345
==========================================
Hits 19582 19582
- Misses 90970 91111 +141
Partials 21846 21846
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ahmeddesokyebrahim
force-pushed
the
autoware/universe/4523-rerouting-static-obstacle
branch
2 times, most recently
from
August 7, 2023 11:40
eeb3dcb
to
f673ae2
Compare
ahmeddesokyebrahim
added
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
and removed
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
labels
Aug 7, 2023
7 tasks
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:common
Common packages from the autoware-common repository. (auto-assigned)
labels
Aug 10, 2023
ahmeddesokyebrahim
force-pushed
the
autoware/universe/4523-rerouting-static-obstacle
branch
from
August 10, 2023 15:20
b1d1c8e
to
0dd2b5a
Compare
ahmeddesokyebrahim
requested review from
isamu-takagi,
kosuke55,
mitsudome-r,
TakaHoribe,
takayuki5168,
purewater0901,
rej55,
kyoichi-sugahara,
mkuri,
soblin,
satoshi-ota,
shmpwk,
taikitanaka3,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
August 10, 2023 16:20
@ahmeddesokyebrahim could you resolve the conflicts for this PR? |
ahmeddesokyebrahim
force-pushed
the
autoware/universe/4523-rerouting-static-obstacle
branch
2 times, most recently
from
March 8, 2024 23:05
3cb712c
to
7cad7dd
Compare
…ic obstacle based on point publisher by the user Signed-off-by: AhmedEbrahim <[email protected]>
Signed-off-by: AhmedEbrahim <[email protected]>
Signed-off-by: AhmedEbrahim <[email protected]>
…rerouting point by the user Signed-off-by: AhmedEbrahim <[email protected]>
Signed-off-by: AhmedEbrahim <[email protected]>
Signed-off-by: AhmedEbrahim <[email protected]>
Signed-off-by: AhmedEbrahim <[email protected]>
Signed-off-by: AhmedEbrahim <[email protected]>
…tion for rerouting in readme file Signed-off-by: AhmedEbrahim <[email protected]>
Signed-off-by: AhmedEbrahim <[email protected]>
…adme file Signed-off-by: AhmedEbrahim <[email protected]>
Signed-off-by: AhmedEbrahim <[email protected]>
Signed-off-by: AhmedEbrahim <[email protected]>
…ed point as point instead of pose Signed-off-by: AhmedEbrahim <[email protected]>
Signed-off-by: AhmedEbrahim <[email protected]>
… being outdated for very long time. Signed-off-by: AhmedEbrahim <[email protected]>
…nges for changing and setting route NOTE : this is still wip and the functionality is not yet finished after this change. Signed-off-by: AhmedEbrahim <[email protected]> feat(reroute-static-obstacle): fixing compilation issue after api changes for changing and setting route NOTE : this is still wip and the functionality is not yet finished after this change. Signed-off-by: AhmedEbrahim <[email protected]>
ahmeddesokyebrahim
force-pushed
the
autoware/universe/4523-rerouting-static-obstacle
branch
from
March 14, 2024 14:35
943d0a1
to
aca5be2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:common
Common packages from the autoware-common repository. (auto-assigned)
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #4523
Related links
Discussion / Idea
Issue
Tests performed
Using planning simulator :
RerouteStaticObstaclePointPublish
plugin using the add plugin sign , then under rviz undertier4_planning_rviz_plugin
-->RerouteStaticObstaclePointPublish
.This video demo shows the testing procedure.
Notes for reviewers
Interface changes
N.A.
Effects on system behavior
Autoware will be able to reroute for road blockage based on input from the user (human driver/operator)
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.
Summary by CodeRabbit
Release Notes:
tier4_planning_rviz_plugin
package.rerouting_static_obstacle_component
) in themission_planner
project for rerouting static obstacles.autoware_auto_mapping_msgs
as a dependency in themission_planner
package.