Feature/clean dockerfile #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platform can be specified at build time using docker `buildx`. Resolves hadolint 3029 https://github.com/hadolint/hadolint/wiki/DL3029 See also: https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/
merging `R` related RUN commands resolves hadolint 3059: https://github.com/hadolint/hadolint/wiki/DL3059
Hard code system dependencies into Dockerfile to avoid changing during build process.
It is better to install them ourselves so we know what is being included
Adding: * libicu-dev (needed by `stringi`) * `pandoc` (needed by `knitr` & `rmarkdown`)
|
Docker image from this PR (c726bb7) created |
|
We can get rid of pandoc if we resolve RMI-PACTA/pacta.portfolio.utils#16 |
This was referenced Nov 17, 2023
Merged
cjyetman
reviewed
Nov 17, 2023
cjyetman
reviewed
Nov 17, 2023
cjyetman
reviewed
Nov 17, 2023
cjyetman
reviewed
Nov 17, 2023
cjyetman
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some general cleaning of the Dockerfile.
Notable Changes:
Rrelated RUN commandspandoc(required via rmarkdown for pacta.portfolio.utils) andlibicu-dev(viastringifor pacta.portfolio.import and .allocate) to sysdeps list--platformin FROM (in favor of specifying platform in build command, see Use docker offical build action #12 )