Feature/multistage #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using https://github.com/docker/build-push-action/ which enables multi-architecture builds and pushing to multiple registries, as well as other features available in buildx (such as build-time secrets)
Platform can be specified at build time using docker `buildx`. Resolves hadolint 3029 https://github.com/hadolint/hadolint/wiki/DL3029 See also: https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/
merging `R` related RUN commands resolves hadolint 3059: https://github.com/hadolint/hadolint/wiki/DL3059
Hard code system dependencies into Dockerfile to avoid changing during build process.
It is better to install them ourselves so we know what is being included
Adding: * libicu-dev (needed by `stringi`) * `pandoc` (needed by `knitr` & `rmarkdown`)
reduce build context by ignoring anything that isn't actually used in the docker image
Using build stages, so the we can use `buildx`'s `no-cache-filters` to force fetching of the latest versions of the pacta packages
|
Docker image from this PR (a3af78e) created |
|
@cjyetman Keeping this as draft until/if the prereqs are merged in, but you can see the proof of concept in the build logs: Using Multistage build with Compare to just using |
cjyetman
reviewed
Nov 17, 2023
cjyetman
reviewed
Nov 17, 2023
cjyetman
reviewed
Nov 17, 2023
cjyetman
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use buildx
--no-cache-filterwith multistage builds to not cache the installation of PACTA packages, but keep the cache for everything else (like system deps)Depends on #14 as base for dockerfile to split into stages.
Depends on #15 to ignore
.gitand.githubdirectoriesDepends on #12 to use
docker buildx