Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker offical build action #12

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Use docker offical build action #12

merged 2 commits into from
Nov 17, 2023

Conversation

AlexAxthelm
Copy link
Contributor

using https://github.com/docker/build-push-action/ which enables multi-architecture builds and pushing to multiple registries, as well as other features available in buildx (such as build-time secrets)

using https://github.com/docker/build-push-action/
which enables multi-architecture builds and pushing to multiple
registries, as well as other features available in buildx (such as
build-time secrets)
@AlexAxthelm AlexAxthelm requested a review from cjyetman November 16, 2023 20:38
Copy link

github-actions bot commented Nov 16, 2023

Docker image from this PR (70e2396) created

docker pull ghcr.io/rmi-pacta/workflow.pacta:pr12

This was referenced Nov 16, 2023
@AlexAxthelm
Copy link
Contributor Author

@cjyetman Please see #16 before approving. As this one stands, it leverages the build cache, but since the command to install the PACTA packages doesn't change, docker buildx build will gladly use the cached version, and not pick up changes from the other repos.

#16 splits the dockerfile into a multistage build, and leverages a feature of buildx to not cache particular stages (in this case, "installing PACTA"). I would highly recommend having that one follow on closely after this one, but it also depends on #15 and #14

@cjyetman
Copy link
Member

@cjyetman Please see #16 before approving. As this one stands, it leverages the build cache, but since the command to install the PACTA packages doesn't change, docker buildx build will gladly use the cached version, and not pick up changes from the other repos.

#16 splits the dockerfile into a multistage build, and leverages a feature of buildx to not cache particular stages (in this case, "installing PACTA"). I would highly recommend having that one follow on closely after this one, but it also depends on #15 and #14

hmmm, yeah that would be pretty bad LOL.... but if you have a plan

@AlexAxthelm AlexAxthelm mentioned this pull request Nov 17, 2023
@AlexAxthelm AlexAxthelm merged commit cc5e300 into main Nov 17, 2023
2 checks passed
@AlexAxthelm AlexAxthelm deleted the feature/use-buildx branch November 17, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants