Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update planetary conditions chance logic #3834

Merged
merged 44 commits into from
Mar 24, 2024

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Feb 9, 2024

requires MegaMek/megamek#5203

  • show changed temperature when it has been adjusted for weather
  • fix issue where rerolls not using the correct terrain when there is a track
  • fix issue when passing fixed maps to megamek, with path character
  • use enums for planetary conditions
  • spilt out board and terrain
    • board - space, atmosphere, and ground
  • use config files to determine terrain
    • filter by temperature
    • highlight terrain when it is set from a track
  • use config files to determine generated map templates from terrain
  • use config file to set weather percentages by terrain type
    • light - standard, dark,
    • wind - standard, high
    • weather - standard, wet, snowy, dry
    • fog - standard, heavy
    • blowing sand - standard, heavy
    • emi - standard, high
  • log validations for the TerrainConditionsOddsManifest.xml config file

image

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: Patch coverage is 0.88889% with 669 lines in your changes are missing coverage. Please review.

Project coverage is 10.60%. Comparing base (d1d1d9a) to head (f7a11a4).

Files Patch % Lines
...ampaign/mission/TerrainConditionsOddsManifest.java 0.00% 368 Missing ⚠️
MekHQ/src/mekhq/gui/view/AtBScenarioViewPanel.java 0.00% 59 Missing ⚠️
MekHQ/src/mekhq/campaign/mission/Scenario.java 0.00% 54 Missing ⚠️
MekHQ/src/mekhq/campaign/mission/AtBScenario.java 0.00% 51 Missing ⚠️
...hq/campaign/mission/AtBDynamicScenarioFactory.java 0.00% 32 Missing ⚠️
MekHQ/src/mekhq/gui/view/ScenarioViewPanel.java 0.00% 27 Missing ⚠️
MekHQ/src/mekhq/GameThread.java 0.00% 12 Missing ⚠️
.../mekhq/campaign/stratcon/StratconRulesManager.java 0.00% 12 Missing ⚠️
...mekhq/gui/dialog/ScenarioTemplateEditorDialog.java 0.00% 11 Missing ⚠️
MekHQ/src/mekhq/AtBGameThread.java 0.00% 10 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3834      +/-   ##
============================================
- Coverage     10.64%   10.60%   -0.04%     
  Complexity     5487     5487              
============================================
  Files           834      836       +2     
  Lines        113857   114263     +406     
  Branches      17193    17183      -10     
============================================
  Hits          12121    12121              
- Misses       100526   100932     +406     
  Partials       1210     1210              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuronekochomusuke kuronekochomusuke marked this pull request as draft February 10, 2024 11:52
@kuronekochomusuke kuronekochomusuke changed the title lower the pitch black light condition chance update planetary conditions chance logic Feb 10, 2024
@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review February 11, 2024 13:01
@kuronekochomusuke kuronekochomusuke marked this pull request as draft February 11, 2024 13:56
@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review February 11, 2024 14:07
@HammerGS HammerGS added the (RFE) Enhancement Requests for Enhancement, new features or implementations label Feb 11, 2024
@kuronekochomusuke kuronekochomusuke marked this pull request as draft February 12, 2024 23:23
@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review February 13, 2024 00:42
@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review February 24, 2024 18:26
@kuronekochomusuke kuronekochomusuke marked this pull request as draft February 28, 2024 23:51
@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review March 9, 2024 16:20
Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been testing and playing this and everything seems to work. Going to merge to allow the tools to run.

@HammerGS HammerGS merged commit eaa80b6 into MegaMek:master Mar 24, 2024
5 of 6 checks passed
@kuronekochomusuke kuronekochomusuke deleted the pitchBlackChance branch April 20, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants