-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 3880 cannot refit clan mechs due to renames #3899
Fix 3880 cannot refit clan mechs due to renames #3899
Conversation
Converted to draft due to CI failures. Will clean up in a bit. |
0d37319
to
f21251e
Compare
Tests broken after pulling latest Planetary Conditions code; should be fixed by /pull/3834 |
Thanks for dealing with the clan name thing. |
There may be some other spots where we'll want to replace |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3899 +/- ##
============================================
+ Coverage 10.64% 10.69% +0.04%
- Complexity 5487 5528 +41
============================================
Files 834 834
Lines 113857 113866 +9
Branches 17193 17196 +3
============================================
+ Hits 12121 12176 +55
+ Misses 100526 100462 -64
- Partials 1210 1228 +18 ☔ View full report in Codecov by Sentry. |
This should fix both Clan configuration changes and custom refits.
Edit: also fixes an NPE when all Techs are occupied and the user wants to start a Refit.
The problem is obviously the requirement to include the Clan unit name in parentheses when doing Clan unit lookups.
I am open to refining this fix further, such as:
but this fix works now, and I don't have time to do any more for probably a week.
Testing:
Close #3880