Planetary Conditions Enums #5203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
SJuliez
requested changes
Mar 20, 2024
There was a problem hiding this comment.
I have a few comments. Also, I suggest placing features in a common package, i.e. to use a package called planetaryconditions in common and having PlanetaryConditions.java and the enums in there. I know that we have all manner of groupings but this seems a sensible way to do it with the (possible) advantage of allowing a low visibility of classes
SJuliez
approved these changes
Mar 23, 2024
|
The CI fails at cache rebuilding. Did you give this a test? (delete the unit cache and rebuild). Might be the test itself has a problem |
|
there was an issue with one of the units that has been fixed a few days ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MegaMek/mekhq#3834 requires this to be merged
convert the int constants to enums