Correct writing to XML of EMI and Blowing Sand conditions #3903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for a bug that was introduced by PR #3834. The XML has stored EMI and blowing sand as boolean conditions. Backwards compatability is respected in the
Scenario.generateInstancefromXML
method. However in thewriteToXML
functions, these conditions are being written as an ordinal numeric value rather than a boolean. The result is that once a campaign is saved again, the EMI and blowingSand conditions, if true, will be lost. This is currently affecting Story Arcs. See AaronGullickson#25 for further discussion.The fix is easy. Just write the results back out as a boolean. I have tested the code and it works correctly.