Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove table ident #2368

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR:

  1. remove TableIdent, use TableId directly
  2. use the latest greptime-proto
  3. independently invalidate table id cache and table name cache

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #2368 (417d4af) into develop (8e70b9e) will decrease coverage by 0.02%.
The diff coverage is 46.63%.

❗ Current head 417d4af differs from pull request most recent head 03a17af. Consider uploading reports for the commit 03a17af to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2368      +/-   ##
===========================================
- Coverage    77.50%   77.48%   -0.02%     
===========================================
  Files          716      714       -2     
  Lines       113959   113043     -916     
===========================================
- Hits         88319    87588     -731     
+ Misses       25640    25455     -185     

src/common/meta/src/cache_invalidator.rs Show resolved Hide resolved
src/datanode/src/heartbeat/handler.rs Outdated Show resolved Hide resolved
src/frontend/src/catalog.rs Show resolved Hide resolved
@WenyXu
Copy link
Member

WenyXu commented Sep 13, 2023

Let's add some flag to the InvalidateTable instruction instead of adding another instruction.

e.g.,

InvalidateTable {
    with_route: bool
} 

By default, with_route is true.

src/common/meta/src/instruction.rs Outdated Show resolved Hide resolved
src/common/meta/src/cache_invalidator.rs Show resolved Hide resolved
src/servers/tests/interceptor.rs Outdated Show resolved Hide resolved
1. remove TableIdent, use TableId directly
2. use the latest greptime-proto
3. independently invalidate table id cache and table name cache
@MichaelScofield MichaelScofield force-pushed the refactor/remove-table-ident branch from 417d4af to 1ac15d0 Compare September 15, 2023 04:46
@MichaelScofield MichaelScofield added this pull request to the merge queue Sep 15, 2023
Merged via the queue into GreptimeTeam:develop with commit fe5679e Sep 15, 2023
10 checks passed
@MichaelScofield MichaelScofield deleted the refactor/remove-table-ident branch September 15, 2023 05:29
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* refactor:
1. remove TableIdent, use TableId directly
2. use the latest greptime-proto
3. independently invalidate table id cache and table name cache

* rebase

* fix: resolve PR comments

* fix: resolve PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants