-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove table ident #2368
Merged
MichaelScofield
merged 4 commits into
GreptimeTeam:develop
from
MichaelScofield:refactor/remove-table-ident
Sep 15, 2023
Merged
refactor: remove table ident #2368
MichaelScofield
merged 4 commits into
GreptimeTeam:develop
from
MichaelScofield:refactor/remove-table-ident
Sep 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2368 +/- ##
===========================================
- Coverage 77.50% 77.48% -0.02%
===========================================
Files 716 714 -2
Lines 113959 113043 -916
===========================================
- Hits 88319 87588 -731
+ Misses 25640 25455 -185 |
WenyXu
reviewed
Sep 13, 2023
Let's add some flag to the e.g.,
By default, |
fengjiachun
reviewed
Sep 13, 2023
2 tasks
MichaelScofield
force-pushed
the
refactor/remove-table-ident
branch
from
September 13, 2023 12:23
9571a2d
to
417d4af
Compare
fengjiachun
approved these changes
Sep 15, 2023
MichaelScofield
force-pushed
the
refactor/remove-table-ident
branch
from
September 15, 2023 04:46
417d4af
to
1ac15d0
Compare
WenyXu
approved these changes
Sep 15, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* refactor: 1. remove TableIdent, use TableId directly 2. use the latest greptime-proto 3. independently invalidate table id cache and table name cache * rebase * fix: resolve PR comments * fix: resolve PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR:
Checklist
Refer to a related PR or issue link (optional)