Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove region id, rename types, remove table ident #2378

Closed
wants to merge 1 commit into from

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Bump greptime-proto to the latest commit GreptimeTeam/greptime-proto@81495b1

Notable changes:

  • remove region id / region number in Frontend services (Database)
  • rename types, e.g., ts_second to timestamp_second
  • remove table ident from proto

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2378 (d8bf8f3) into develop (9c76d2c) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is 59.67%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2378   +/-   ##
========================================
  Coverage    77.54%   77.55%           
========================================
  Files          716      716           
  Lines       113722   113665   -57     
========================================
- Hits         88188    88148   -40     
+ Misses       25534    25517   -17     

@waynexia
Copy link
Member Author

duplicated with #2368

@waynexia waynexia closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant