Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses full table name as a lock key during the failover procedure. #2738

Closed
WenyXu opened this issue Nov 14, 2023 · 2 comments
Closed

Uses full table name as a lock key during the failover procedure. #2738

WenyXu opened this issue Nov 14, 2023 · 2 comments
Labels
C-enhancement Category Enhancements

Comments

@WenyXu
Copy link
Member

WenyXu commented Nov 14, 2023

What type of enhancement is this?

Tech debt reduction

What does the enhancement do?

We should use the full table name as a lock key like we did in other procedures(e.g., here)

fn lock_key(&self) -> LockKey {
let region_ident = &self.node.failed_region;
let region_key = format!(
"{}/region-{}",
region_ident.table_id, region_ident.region_number
);
LockKey::single(region_key)
}

The lock was removed accidentally in #2368

Implementation challenges

No response

@WenyXu WenyXu added C-enhancement Category Enhancements good first issue Good for newcomers help wanted Extra attention is needed labels Nov 14, 2023
@Dysprosium0626
Copy link
Contributor

It seems like an easy task and good start for beginner like me.
Can you assign this to me?

@WenyXu
Copy link
Member Author

WenyXu commented Nov 22, 2023

It seems like an easy task and good start for beginner like me. Can you assign this to me?

Sorry, this issue might need some future discussion; how about looking for other good first issues? Thank you 😊

@WenyXu WenyXu removed good first issue Good for newcomers help wanted Extra attention is needed labels Nov 22, 2023
@WenyXu WenyXu closed this as completed Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements
Projects
None yet
Development

No branches or pull requests

2 participants