fix: resolve PR comments

GreptimeTeam · Sep 13, 2023 · 417d4af · 417d4af
1 parent 2641ea5
commit 417d4af
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/src/common/meta/src/instruction.rs b/src/common/meta/src/instruction.rs
@@ -15,7 +15,7 @@
 use std::fmt::{Display, Formatter};
 
 use serde::{Deserialize, Serialize};
-use store_api::storage::RegionId;
+use store_api::storage::{RegionId, RegionNumber};
 use strum::Display;
 use table::metadata::TableId;
 
@@ -27,7 +27,7 @@ pub struct RegionIdent {
     pub cluster_id: ClusterId,
     pub datanode_id: DatanodeId,
     pub table_id: TableId,
-    pub region_number: u32,
+    pub region_number: RegionNumber,
 }
 
 impl RegionIdent {

diff --git a/src/servers/tests/interceptor.rs b/src/servers/tests/interceptor.rs
@@ -72,10 +72,7 @@ fn test_grpc_interceptor() {
     let ctx = QueryContext::arc();
 
     let req = Request::Inserts(InsertRequests {
-        inserts: vec![InsertRequest {
-            row_count: 0,
-            ..Default::default()
-        }],
+        inserts: vec![InsertRequest::default()],
     });
 
     let fail = GrpcQueryInterceptor::pre_execute(&di, &req, ctx.clone());

diff --git a/src/table/src/metadata.rs b/src/table/src/metadata.rs
@@ -448,6 +448,8 @@ pub struct TableInfo {
     /// Id and version of the table.
     #[builder(default, setter(into))]
     pub ident: TableIdent,
+
+    // TODO(LFC): Remove the catalog, schema and table names from TableInfo.
     /// Name of the table.
     #[builder(setter(into))]
     pub name: String,