-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Secrets SDK with Rust keyring bindings #222
Conversation
Co-authored-by: Trae Yelovich <[email protected]> Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
+ Coverage 82.88% 83.16% +0.27%
==========================================
Files 33 34 +1
Lines 2115 2067 -48
==========================================
- Hits 1753 1719 -34
+ Misses 362 348 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <[email protected]>
135cfc3
to
52a465e
Compare
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
8d47a35
to
8a92ece
Compare
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
689fb17
to
505de34
Compare
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
7d7852b
to
42c222d
Compare
Signed-off-by: Timothy Johnson <[email protected]>
42c222d
to
3114108
Compare
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel awkward approving this, as I had some commits on this PR and did some related work to prepare the secrets_core crate 😅
But, everything LGTM though - thanks @t1m0thyj
Signed-off-by: Timothy Johnson <[email protected]>
8817566
to
917ebd7
Compare
Enable release workflows to publish prerelease to PyPI
Signed-off-by: Timothy Johnson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Seems to work just fine with more than just ascii 😋
What It Does
Resolves #208 by adding Python to Rust bindings that use the same keyring backend as the Node SDK.
Replaced all references to the
keyring
package with our ownkeyring
subpackage in the Secrets SDK.Added Secrets SDK as an optional dependency of the core SDK that can be installed with the
secrets
feature.How to Test
Reinstall dependencies after pulling this branch. The install script for Secrets SDK should build the keyring binary.
Manually test the methods of the
keyring
package with this script:Review Checklist
I certify that I have:
Additional Comments
Coauthored with @traeok 🙂