Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secrets): Core crate to expose Rust modules as library #1844

Merged
merged 11 commits into from
Nov 14, 2023

Conversation

traeok
Copy link
Member

@traeok traeok commented Nov 6, 2023

What It Does

This PR implements the following changes for the Secrets SDK:

  • Exposes the Rust core logic as a crate named secrets_core so that other languages can leverage it to create bindings
    • See PR 222 on the Python SDK 😋
  • Adjusts the Rust crate so it can be imported by other Rust-powered Zowe projects (such as the daemon)
  • Adds basic unit tests to the secrets_core crate

How to Test

Build the Secrets SDK package using npm run build - compilation should succeed.

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d775c37) 91.06% compared to head (970a95d) 91.06%.
Report is 1 commits behind head on master.

❗ Current head 970a95d differs from pull request most recent head bc046f3. Consider uploading reports for the commit bc046f3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1844   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files         636      636           
  Lines       18709    18709           
  Branches     3898     3898           
=======================================
  Hits        17037    17037           
  Misses       1671     1671           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@traeok traeok marked this pull request as ready for review November 6, 2023 23:28
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel awkward approving this PR since I pushed a commit, but changes LGTM 👍

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run into any issues with the build.
LGTM! 😋

@zFernand0 zFernand0 mentioned this pull request Nov 14, 2023
4 tasks
@zFernand0
Copy link
Member

I believe we landed on no-changelog required for the secrets_core crate.

Note:

  • The only other PR merged before this one was the Readme updates.

Merging and labeling as release-current

@zFernand0 zFernand0 merged commit 1b4d492 into master Nov 14, 2023
13 of 17 checks passed
@zFernand0 zFernand0 deleted the feat/secrets/core-crate branch November 14, 2023 14:10
@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-current Indicates that there is no new functionality being delivered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants