-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(secrets): Core crate to expose Rust modules as library #1844
Conversation
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1844 +/- ##
=======================================
Coverage 91.06% 91.06%
=======================================
Files 636 636
Lines 18709 18709
Branches 3898 3898
=======================================
Hits 17037 17037
Misses 1671 1671
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel awkward approving this PR since I pushed a commit, but changes LGTM 👍
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't run into any issues with the build.
LGTM! 😋
I believe we landed on Note:
Merging and labeling as |
What It Does
This PR implements the following changes for the Secrets SDK:
secrets_core
so that other languages can leverage it to create bindingssecrets_core
crateHow to Test
Build the Secrets SDK package using
npm run build
- compilation should succeed.Review Checklist
I certify that I have:
Additional Comments