Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Don't change log level of global logger #207

Closed
t1m0thyj opened this issue Aug 29, 2023 · 2 comments · Fixed by #222
Closed

[core] Don't change log level of global logger #207

t1m0thyj opened this issue Aug 29, 2023 · 2 comments · Fixed by #222
Labels
bug Something isn't working good first issue Good for newcomers priority-low severity-medium

Comments

@t1m0thyj
Copy link
Member

Calling logging.getLogger().setLevel may have undesired effects on applications using the SDK:

logging.getLogger().setLevel(logging.ERROR)

The warning we are trying to hide comes from the Python keyring package when used on Windows:
https://github.com/jaraco/keyring/blob/af7233958ece36da8d493509a6388484f5534dfc/keyring/backends/Windows.py#L56-L59

We could investigate using the warnings.filterwarnings method instead to hide only the "Retrieved an UTF-8 encoded credential" warning and continue to log other ones.

@t1m0thyj t1m0thyj added bug Something isn't working good first issue Good for newcomers priority-low severity-medium labels Aug 29, 2023
@github-actions
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@t1m0thyj t1m0thyj changed the title [zos-core] Don't change log level of global logger [core] Don't change log level of global logger Aug 29, 2023
@t1m0thyj
Copy link
Member Author

t1m0thyj commented Dec 3, 2023

Fixed in 70d62ee since we no longer use the keyring package

@t1m0thyj t1m0thyj closed this as completed Dec 3, 2023
@t1m0thyj t1m0thyj linked a pull request Dec 3, 2023 that will close this issue
11 tasks
@t1m0thyj t1m0thyj moved this to Closed in Zowe CLI Squad Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers priority-low severity-medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant