Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auto-upload Published] Full publishing and cancellation flow #12240

Closed
11 of 12 tasks
shiki opened this issue Jul 30, 2019 · 4 comments
Closed
11 of 12 tasks

[Auto-upload Published] Full publishing and cancellation flow #12240

shiki opened this issue Jul 30, 2019 · 4 comments

Comments

@shiki
Copy link
Member

shiki commented Jul 30, 2019

This covers the following part of #12227:

60972121-8ad36680-a31d-11e9-930b-e5d3f3fd79fc jpg (1320×3178) 2019-07-30 16-14-40

Test Cases

Drafts

Test Case Status

Post stays in Drafts and SnackBar appears

Status: Android and iOS show different messages.

Local drafts are automatically uploaded as drafts ✔️ #11839 #12215
Drafts with un-confirmed changes are remote-auto-saved
Drafts with confirmed changes are automatically uploaded

Publishing

Test Case Status
When offline:
  • Post stays in Drafts or previous remote status
  • SnackBar appears: "Post will be published next time your device is online"
Post List:
  • Status message: "Post will be published next time your device is online""
  • Cancel button is shown"
Cancellation
  • Post stays in Drafts or previous remote status
  • SnackBar: "Changes will not be published"
Published posts with confirmed changes are automatically uploaded.
Published posts with UN-confirmed changes are remote-auto-saved
Cancelled posts are remote-auto-saved not auto-uploaded.
It should be possible to revert a published post to a draft.
When a draft is uploaded, pressing on the notice's Publish button should auto-upload the post as published
Tapping on Publish in the Post List should auto-upload the post

Additional scenarios

  • A post with a failed media upload

Plan

It looks like all parts have to be there in order to merge these to develop. We will create multiple PRs but target a master branch instead.

Most of the work has been done by @diegoreymendez in PR #12178. We're going to take it apart into smaller chunks. And then we're going to need to test everything before merging to develop.

Targeting the PUBLISHED is deliberate to decrease the risks of regressions. If everything works great, we can apply the same to other statuses.

Known Tasks

@shiki
Copy link
Member Author

shiki commented Jul 30, 2019

@osullivanchris I'm sorry if this has already been answered somewhere. For the requirement, "Post stays in drafts". If the post was previously published, should it still show in Drafts?

@osullivanchris
Copy link

@shiki no I think that would imply that it has been 'unpublished'. I'm not sure if we previously addressed it so its good to call out. I think it would be in published, and a message saying "Post will be updated next time your device is online" would make it clear what to expect. WDYT?

@shiki
Copy link
Member Author

shiki commented Jul 31, 2019

@osullivanchris That sounds great! Thank you.

@shiki shiki changed the title Offline Publishing - Auto-uploading PUBLISHED and cancellation Offline Publishing - Auto-uploading published and cancellation Jul 31, 2019
@shiki shiki changed the title Offline Publishing - Auto-uploading published and cancellation [Auto-upload Published] Full publishing and cancellation flow Aug 6, 2019
@shiki shiki removed their assignment Aug 8, 2019
@shiki shiki self-assigned this Aug 14, 2019
@shiki
Copy link
Member Author

shiki commented Sep 30, 2019

Closing this since we're very close to finishing and we're now targeting #12227.

@shiki shiki closed this as completed Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants