Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Offline Posting] Do not automatically retry upload after 3 failures #12369

Closed
1 of 3 tasks
shiki opened this issue Aug 22, 2019 · 5 comments
Closed
1 of 3 tasks

[Offline Posting] Do not automatically retry upload after 3 failures #12369

shiki opened this issue Aug 22, 2019 · 5 comments

Comments

@shiki
Copy link
Member

shiki commented Aug 22, 2019

📣 Part of #12240. Please use the issue/12240-master-branch as the target branch.

In Android, wordpress-mobile/WordPress-Android#10059, we ran into an issue where a post can be automatically uploaded indefinitely. There can be many reasons for this but one of the reasons can be that the user doesn't have permission to upload to the site.

We should also add this for iOS to preemptively avoid this scenario.

See UploadActionUseCase for how it is implemented on Android.

Known Tasks

@shiki
Copy link
Member Author

shiki commented Aug 22, 2019

@malinajirka Are we still going with a maximum of 10 failures?

@malinajirka
Copy link

Hmm I know we discussed going with 3 retries and changing the copy based on the retry count, right? I can't find that conversation and I don't remember what we decided 😞.

@malinajirka
Copy link

Found it :) - we'll soon have only 3 retries on android. More info wordpress-mobile/WordPress-Android#10370

@shiki shiki changed the title [Auto-upload Published] Do not automatically retry upload after 10 failures [Auto-upload Published] Do not automatically retry upload after 3 failures Aug 23, 2019
@shiki
Copy link
Member Author

shiki commented Aug 23, 2019

@malinajirka Thanks, I tried looking for it yesterday. 😄

@shiki
Copy link
Member Author

shiki commented Sep 27, 2019

Messages to be shown in the Post List are described in wordpress-mobile/WordPress-Android#10370 (comment).

@leandroalonso leandroalonso self-assigned this Sep 27, 2019
@shiki shiki changed the title [Auto-upload Published] Do not automatically retry upload after 3 failures [Offline Posting] Do not automatically retry upload after 3 failures Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants