Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Offline Posting] Add a feature flag that toggles automatic uploading #12370

Closed
shiki opened this issue Aug 22, 2019 · 4 comments
Closed

[Offline Posting] Add a feature flag that toggles automatic uploading #12370

shiki opened this issue Aug 22, 2019 · 4 comments

Comments

@shiki
Copy link
Member

shiki commented Aug 22, 2019

📣 Part of #12240. Please use the issue/12240-master-branch as the target branch.

As a pre-emptive measure, we can add a feature flag that toggles the automatic uploading.

We can possibly use the FeatureFlag enum.

@shiki
Copy link
Member Author

shiki commented Aug 22, 2019

@diegoreymendez tagging you in case you have an objection for this. I believe you mentioned this once.

@shiki shiki changed the title [Auto-upload Published] Add a feature flag that toggles automatic uploading [Offline Posting] Add a feature flag that toggles automatic uploading Oct 1, 2019
@yaelirub yaelirub self-assigned this Oct 8, 2019
@yaelirub
Copy link
Contributor

yaelirub commented Oct 8, 2019

@shiki , I started working on implementation for this but I am not sure we should do this.
My concern is that if we every choose to disable it and than re-enable it, posts that were failed to upload will get auto uploaded or the UI won't make sense.

Are we doing this on Android?

Why is this feature a good candidate for a feature flag?

@shiki
Copy link
Member Author

shiki commented Oct 8, 2019

Thank you for the info, @yaelirub. This was mostly born out of @diegoreymendez's concern of “what if this causes a major bug”. He mentioned once that we should think about how to react quickly if that happens.

If you think this causes more trouble than it's worth, and it sounds that way, then I'm okay with abandoning it.

We don't have this on Android.

@yaelirub
Copy link
Contributor

yaelirub commented Oct 8, 2019

Thanks @shiki !
Ok then. I'm going to close this one and if we ever see a reason to pursue it, I'll create a new ticket so we can discuss.

@yaelirub yaelirub closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants