Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auto-upload Published] Show notice after canceling #12325

Closed
shiki opened this issue Aug 14, 2019 · 1 comment
Closed

[Auto-upload Published] Show notice after canceling #12325

shiki opened this issue Aug 14, 2019 · 1 comment
Assignees
@yaelirub
Labels
Offline Support [Pri] Medium [Type] Task

Comments

@shiki
Copy link
Member

shiki commented Aug 14, 2019

📣 Part of #12240. This is a continuation of the #12317 PR and requires that to be merged first. Any fixes should target the issue/12240-master-branch branch.

In #12317, we added a Cancel button on the Post List for locally published posts. To follow the spec described in #12240, pressing the Cancel button should show a notice:

notice

Please note that the message has been changed to “Changes will not be published“ instead of the one shown in the image.
@shiki shiki mentioned this issue Aug 14, 2019
Merged
1 task
@yaelirub yaelirub added [Status] Blocked Waiting for a different task to be able to proceed and removed [Status] Blocked Waiting for a different task to be able to proceed labels Aug 15, 2019
@yaelirub yaelirub self-assigned this Aug 22, 2019
@yaelirub yaelirub mentioned this issue Aug 22, 2019
Merged
1 task
@diegoreymendez
Copy link
Contributor

Closing this issue as the connected PR seems to have fixed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaelirub yaelirub

Labels
Offline Support [Pri] Medium [Type] Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shiki @yaelirub @diegoreymendez