Damage Coeff Change Standardization #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LanceSmites328
added
Code improvement
LanceSmites328
force-pushed
the
Damage-Coeff-Standarization
branch
from
bad7cfb to
a2a3329
Compare
Merged
Kitsunemitsu
requested changes
Sep 12, 2023
LanceSmites328
force-pushed
the
Damage-Coeff-Standarization
branch
from
1204a8e to
98301a4
Compare
LanceSmites328
force-pushed
the
Damage-Coeff-Standarization
branch
from
98301a4 to
5d760d9
Compare
LanceSmites328
force-pushed
the
Damage-Coeff-Standarization
branch
from
ab31b41 to
c68bf20
Compare
Changes "damage_coeff =" to "ChangeResistances("
Changes "Unmodified_Coeff" to "Unmodified_Damage_Coeff"
Returns the status check as opposed to the mod check
Adds ModifyResistances proc and fixing spelling error
Update damage_coeff_helper.dm
Entire Rework of how I've done this
Call this shit "Armor 2"
LanceSmites328
force-pushed
the
Damage-Coeff-Standarization
branch
from
c68bf20 to
2945987
Compare
LanceSmites328
added
the
Test Merge Candidate
EgorDinamit
removed
the
Test Merge Candidate
EgorDinamit
approved these changes
Oct 28, 2023
vampirebat74
pushed a commit
to vampirebat74/lobotomy-corp13
that referenced
this pull request
May 10, 2024
* Temporary Starting Commit
Changes "damage_coeff =" to "ChangeResistances("
Changes "Unmodified_Coeff" to "Unmodified_Damage_Coeff"
Returns the status check as opposed to the mod check
Adds ModifyResistances proc and fixing spelling error
Update damage_coeff_helper.dm
Entire Rework of how I've done this
Call this shit "Armor 2"
* Old Code Update
* code improvement
* God of Seasons update
* Updates damage_coeff checks with new Proc
* Deep Scanner Update
* linter fixes
* Converts current damage_coeff system to mimic armor
* Update _abnormality.dm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Creates a system of datums that can be used to properly manage changes to a
simple_animal's damage_coeff without causing issues, such as a debuff wearing off after the animal re-defines it's resistances, causing it to buff those resistances further.So, this now also rewrites existing
damage_coeffcode to use a new datum that is extremely similar to armor for the purposes of performance, as the old way of optimization using lists was simply not compatible.These modifiers are meant to typically be provided by status effects that later remove them. Some cases, such as Doomsday Calendar are exceptions, due to their theoretically infinitely scaling self-debuff.
This should probably be stress tested a bit.
Why It's Good For The Game
Solves issues of incredible resistances by stuff like Arbiter when faced with certain realized EGO.
Allows armor debuffs to be used more realistically without worrying about certain issues.