Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworks some TETH abnormalities #1522

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

Coxswain-Navigator
Copy link
Contributor

@Coxswain-Navigator Coxswain-Navigator commented Oct 13, 2023

About The Pull Request

Improves some abnormalities that I feel are a bit incomplete

  • Fairy Long Legs now has visual effects for the rain instead of making players use their imagination. It was fine otherwise.
  • Fairy Gentleman now has a breach, and is a bit more difficult to squeeze for infinite easy sanity healing. In addition, I rewrote all of the dialogue because they didn't seem to be written by a native speaker. I may have gone a bit overboard when trying to make the dialogue seem interesting.
  • So That No One Will Cry now has a breach and mechanics that lead to a breach as well.
  • SO That No One Will Cry work damaged changed from WHITE to BLACK
  • Changes some TETH gifts from HATs to HELMETs. I ran the numbers and there were 10+ "hat" gifts and NO helmet gifts whatsoever. Also gives a helmet gift to so that no one will cry.

Thanks to Mel Taculo for making the sprites on such short notice.

Why It's Good For The Game

More variety for our early abnormalities

Changelog

🆑
tweak: tweaked some TETH abnormalities
/:cl:

@Coxswain-Navigator Coxswain-Navigator added the Tweak A small change/addition to already existing systems. label Oct 13, 2023
@Coxswain-Navigator Coxswain-Navigator marked this pull request as draft October 13, 2023 20:50
@Coxswain-Navigator Coxswain-Navigator force-pushed the teth-rework branch 2 times, most recently from 7178d74 to 28b710a Compare October 14, 2023 00:26
@Coxswain-Navigator Coxswain-Navigator marked this pull request as ready for review October 14, 2023 00:26
@Coxswain-Navigator Coxswain-Navigator force-pushed the teth-rework branch 6 times, most recently from 54c58a4 to 13ac535 Compare October 17, 2023 04:05
@Coxswain-Navigator Coxswain-Navigator force-pushed the teth-rework branch 4 times, most recently from 98c2c84 to a162a02 Compare October 20, 2023 07:36
@Coxswain-Navigator Coxswain-Navigator force-pushed the teth-rework branch 3 times, most recently from 8945cef to bcc3ab8 Compare October 22, 2023 05:51
@Coxswain-Navigator Coxswain-Navigator force-pushed the teth-rework branch 2 times, most recently from 5a389be to 23162ae Compare October 28, 2023 16:43
wraps up fairy long legs

adds fairy gentleman breach

cool so that no one will cry stuff

finishes the pr

prevents some weirdness

buffs hp

gift changes

Update code/modules/mob/living/simple_animal/abnormality/teth/fairy_gentleman.dm

Co-authored-by: [̸R̵e̵d̴a̴c̶t̸e̸d̴]̵ <[email protected]>

Fixes stuff

fixes a bug

changes names

Removes armortype, changes so that no one will cry from white to black damage

rebased and updated to reflect new resistance PR
ChangeResistances(list(BRUTE = 1, RED_DAMAGE = 0, WHITE_DAMAGE = 0, BLACK_DAMAGE = 0, PALE_DAMAGE = 0))
SLEEP_CHECK_DEATH(10 SECONDS)
icon_state = icon_living
ChangeResistances(list(BRUTE = 1, RED_DAMAGE = 1.5, WHITE_DAMAGE = 1, BLACK_DAMAGE = 1, PALE_DAMAGE = 2))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up, the Brute change here and in the previous one is redundant, as this proc only changes the provided resistances. Not a real issue but I should let you know.

@LanceSmites328 LanceSmites328 merged commit 5da4951 into vlggms:master Oct 31, 2023
7 checks passed
@Coxswain-Navigator Coxswain-Navigator deleted the teth-rework branch October 31, 2023 01:15
vampirebat74 pushed a commit to vampirebat74/lobotomy-corp13 that referenced this pull request May 10, 2024
TETH rework

wraps up fairy long legs

adds fairy gentleman breach

cool so that no one will cry stuff

finishes the pr

prevents some weirdness

buffs hp

gift changes

Update code/modules/mob/living/simple_animal/abnormality/teth/fairy_gentleman.dm

Co-authored-by: [̸R̵e̵d̴a̴c̶t̸e̸d̴]̵ <[email protected]>

Fixes stuff

fixes a bug

changes names

Removes armortype, changes so that no one will cry from white to black damage

rebased and updated to reflect new resistance PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak A small change/addition to already existing systems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants