-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse Unikemet #855
Parse Unikemet #855
Conversation
unicodetools/src/main/resources/org/unicode/props/ExtraPropertyValueAliases.txt
Show resolved
Hide resolved
# Egyptian hieroglyph invariants | ||
|
||
Let $unikemetScope = [\p{Block=/^Egyptian.Hieroglyphs/} - \p{gc=Cn}] | ||
$unikemetScope = [ [\p{gc=Lo} & \p{sc=Egyp}] - \p{Name=/^EGYPTIAN HIEROGLYPH (FULL |HALF |TALL |WIDE )?(BLANK|LOST SIGN)$/} ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just FYI: I always stumble a little over "=" meaning "assign" on a "Let" line but "assertEquals" on a test line (without a statement prefix) ... It would be a disruptive change, but using "==" for "assertEquals" might make this file more obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or := (or ≔?) in Let
(that would keep the actual invariant statements closer to normal mathematical operators on sets).
Not today, but good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let with ASCII := would be ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but we need to remember that if UTC-180 disagrees with the PA/PVA additions, then we will need to move these back to the Extra files
# Egyptian hieroglyph invariants | ||
|
||
Let $unikemetScope = [\p{Block=/^Egyptian.Hieroglyphs/} - \p{gc=Cn}] | ||
$unikemetScope = [ [\p{gc=Lo} & \p{sc=Egyp}] - \p{Name=/^EGYPTIAN HIEROGLYPH (FULL |HALF |TALL |WIDE )?(BLANK|LOST SIGN)$/} ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let with ASCII := would be ok
CI failure:
|
Ah yes, I went too far in my removal in Extra, and there’s an illustration of the answer on needing those lines for the binaries 😩 |
Or if UTC does not take the decision recommended by https://github.com/unicode-org/sah/issues/496 (I kept Core in Extra in anticipation of that). |
No description provided.