Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Unikemet #855

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Parse Unikemet #855

merged 5 commits into from
Jun 7, 2024

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Jun 6, 2024

No description provided.

# Egyptian hieroglyph invariants

Let $unikemetScope = [\p{Block=/^Egyptian.Hieroglyphs/} - \p{gc=Cn}]
$unikemetScope = [ [\p{gc=Lo} & \p{sc=Egyp}] - \p{Name=/^EGYPTIAN HIEROGLYPH (FULL |HALF |TALL |WIDE )?(BLANK|LOST SIGN)$/} ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just FYI: I always stumble a little over "=" meaning "assign" on a "Let" line but "assertEquals" on a test line (without a statement prefix) ... It would be a disruptive change, but using "==" for "assertEquals" might make this file more obvious.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or := (or ≔?) in Let (that would keep the actual invariant statements closer to normal mathematical operators on sets).

Not today, but good idea.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let with ASCII := would be ok

@eggrobin eggrobin requested a review from markusicu June 6, 2024 18:10
markusicu
markusicu previously approved these changes Jun 6, 2024
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but we need to remember that if UTC-180 disagrees with the PA/PVA additions, then we will need to move these back to the Extra files

# Egyptian hieroglyph invariants

Let $unikemetScope = [\p{Block=/^Egyptian.Hieroglyphs/} - \p{gc=Cn}]
$unikemetScope = [ [\p{gc=Lo} & \p{sc=Egyp}] - \p{Name=/^EGYPTIAN HIEROGLYPH (FULL |HALF |TALL |WIDE )?(BLANK|LOST SIGN)$/} ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let with ASCII := would be ok

@markusicu
Copy link
Member

CI failure:

Error:  org.unicode.propstest.TestProperties.TestDefaults  Time elapsed: 2.912 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: Null kEH_NoMirror for U+FFFF but property is Binary with default value type LITERAL. Add an @missing line to ExtraPropertyValueAliases.txt if needed. ==> expected: not <null>
	at org.unicode.propstest.TestProperties.TestDefaults(TestProperties.java:614)

@eggrobin
Copy link
Member Author

eggrobin commented Jun 6, 2024

CI failure:

Ah yes, I went too far in my removal in Extra, and there’s an illustration of the answer on needing those lines for the binaries 😩

@eggrobin
Copy link
Member Author

eggrobin commented Jun 6, 2024

lgtm but we need to remember that if UTC-180 disagrees with the PA/PVA additions, then we will need to move these back to the Extra files

Or if UTC does not take the decision recommended by https://github.com/unicode-org/sah/issues/496 (I kept Core in Extra in anticipation of that).

@eggrobin eggrobin requested a review from markusicu June 6, 2024 23:31
@eggrobin eggrobin merged commit d51c407 into unicode-org:main Jun 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants