Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow invariant test statements to extend over multiple lines #865

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

eggrobin
Copy link
Member

No semicolons for now; the current grammar almost didn’t need them.
The compound properties on the right-hand side of OnPairsOf and In lines were too greedy and started parsing the keyword at the beginning of the next test; but disallowing newlines in property names solves the problem and does not seem like a big problem anyway.

Maybe at some point we will want to add semicolons just for readability (and better parse errors).

Note that I still plan to do the := thing, but I will do it separately.

@eggrobin eggrobin requested review from markusicu and macchiati June 26, 2024 00:14
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eggrobin eggrobin merged commit fd4bf35 into unicode-org:main Jun 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants