Use := for definitions in the invariant tests #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusicu
reviewed
Jun 30, 2024
unicodetools/src/main/java/org/unicode/text/UCD/TestUnicodeInvariants.java
Outdated
Show resolved
Hide resolved
| for (String s : sequences) { | ||
| if (candidate.token.equals(s)) { | ||
| result = candidate; | ||
| break; |
There was a problem hiding this comment.
I think you want to break out of the outer loop here as well. If so, the simplest would be to just return candidate; right here.
There was a problem hiding this comment.
I don’t want to break here; I could be looking for == or ===, and in that case I would want to wait until I get ===.
unicodetools/src/main/java/org/unicode/text/UCD/TestUnicodeInvariants.java
Outdated
Show resolved
Hide resolved
markusicu
reviewed
Jul 4, 2024
unicodetools/src/main/java/org/unicode/text/UCD/GenerateBreakTest.java
Outdated
Show resolved
Hide resolved
unicodetools/src/main/resources/org/unicode/tools/SegmenterDefault.txt
Outdated
Show resolved
Hide resolved
markusicu
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #855 (comment) sqq.
Since Markus wanted := rather than ≔ this takes a bit of restructuring of the parser; I wrote it in a way that should avoid running into the C++03 >> problem in the future.