CLDR-16844 Fix bug in last PR: require parameter for cldrInfo.closePanel #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Add the boolean parameter for both callers -Log error to console if parameter is undefined
|
Obviously I didn't test the previous PR thoroughly! I tested it for the desired new behavior, that the panel reappears when it had been closed automatically, but I didn't test for the old behavior that it stays closed if it had been closed manually |
macchiati
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add the boolean parameter for both callers
-Log error to console if parameter is undefined
CLDR-16844
ALLOW_MANY_COMMITS=true