Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16844 Fix bug in last PR: require parameter for cldrInfo.closePanel #3872

Merged
merged 1 commit into from
Jul 17, 2024
Merged

CLDR-16844 Fix bug in last PR: require parameter for cldrInfo.closePanel #3872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tools/cldr-apps/js/src/esm/cldrInfo.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@ function openPanel() {
* false if closing because switching to a "special" view where the Info Panel doesn't belong
*/
function closePanel(userWantsHidden) {
if (userWantsHidden === undefined) {
console.error("cldrInfo.closePanel was called with undefined parameter");
}
if (panelVisible) {
panelVisible = false;
panelWanted = !userWantsHidden;
Expand Down
2 changes: 1 addition & 1 deletion tools/cldr-apps/js/src/esm/cldrLoad.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ function specialLoad(itemLoadInfo, curSpecial, theDiv) {
if (curSpecial !== "general") {
cldrGui.hideDashboard();
}
cldrInfo.closePanel();
cldrInfo.closePanel(false /* userWantsHidden */);
// Most special.load() functions do not use a parameter; an exception is
// cldrGenericVue.load() which expects the special name as a parameter
if (CLDR_LOAD_DEBUG) {
Expand Down
2 changes: 1 addition & 1 deletion tools/cldr-apps/js/src/views/InfoPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export default {
},
methods: {
closeInfoPanel() {
cldrInfo.closePanel();
cldrInfo.closePanel(true /* userWantsHidden */);
},

reloadInfoPanel() {
Expand Down
Loading