CLDR-16844 Fix bug in last PR: require parameter for cldrInfo.closePa…

…nel (#3872)
unicode-org · Jul 17, 2024 · 7b03b2d · 7b03b2d
1 parent 49c74ad
commit 7b03b2d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/tools/cldr-apps/js/src/esm/cldrInfo.mjs b/tools/cldr-apps/js/src/esm/cldrInfo.mjs
@@ -143,6 +143,9 @@ function openPanel() {
  *       false if closing because switching to a "special" view where the Info Panel doesn't belong
  */
 function closePanel(userWantsHidden) {
+  if (userWantsHidden === undefined) {
+    console.error("cldrInfo.closePanel was called with undefined parameter");
+  }
   if (panelVisible) {
     panelVisible = false;
     panelWanted = !userWantsHidden;

diff --git a/tools/cldr-apps/js/src/esm/cldrLoad.mjs b/tools/cldr-apps/js/src/esm/cldrLoad.mjs
@@ -612,7 +612,7 @@ function specialLoad(itemLoadInfo, curSpecial, theDiv) {
     if (curSpecial !== "general") {
       cldrGui.hideDashboard();
     }
-    cldrInfo.closePanel();
+    cldrInfo.closePanel(false /* userWantsHidden */);
     // Most special.load() functions do not use a parameter; an exception is
     // cldrGenericVue.load() which expects the special name as a parameter
     if (CLDR_LOAD_DEBUG) {

diff --git a/tools/cldr-apps/js/src/views/InfoPanel.vue b/tools/cldr-apps/js/src/views/InfoPanel.vue
@@ -54,7 +54,7 @@ export default {
   },
   methods: {
     closeInfoPanel() {
-      cldrInfo.closePanel();
+      cldrInfo.closePanel(true /* userWantsHidden */);
     },
 
     reloadInfoPanel() {