Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maps support for DIP switch settings #91

Merged
merged 10 commits into from
Jan 13, 2025
Merged

Add maps support for DIP switch settings #91

merged 10 commits into from
Jan 13, 2025

Conversation

tomlogic
Copy link
Owner

@tomlogic tomlogic commented Jan 10, 2025 •
edited
Loading

Still a bit more work here before dip switches can be official.

  • Rename this file and put it in the correct location.
  • Remove victory from gottlieb_80b-2.nv.json.
  • Document dipsw encoding.
  • Document new _values metadata.
  • Replace all _note tags with _notes.
  • Update index.json.

@tomlogic
nv_23x: fix buy-in high scores & add checksum16
82da91e 
Corrects score offsets and adds that region to the checksum16 list.

I didn't see this error before, because I wasn't dumping the
undocumented "buyin_high_scores" section.  The map before
commit 4a36bc2 was off by a factor of 100 because it had the
wrong length for each Buy-In High Score.  Fixes #84.
@tomlogic
cleanup: run reformat-map.sh for all maps
589332e
@tomlogic
ci: reformat all maps in subdirectories
06b9d98
@tomlogic
cleanup: standardize on "_notes" over "_note"
9133670 
Resolves #85.
@tomlogic
tools: deprecate _note via normalize-map.py
48e458d
@tomlogic
doc: _notes can be a string or array of strings
caaf868
@tomlogic tomlogic force-pushed the feature/dipsw branch 2 times, most recently from dc8f985 to cbe972d Compare January 10, 2025 23:51
@tomlogic
Copy link
Owner Author

Resolves #48.

@tomlogic tomlogic changed the title victory: JSON file for dip switch testing Add maps support for DIP switch settings Jan 11, 2025
@tomlogic tomlogic marked this pull request as ready for review January 11, 2025 01:01
@tomlogic
Copy link
Owner Author

@francisdb, I think I'm ready to include the DIP switch support now. I'll look over my README changes again tomorrow -- let me know if I could be clearer in certain sections, or left anything out.

@tomlogic tomlogic mentioned this pull request Jan 11, 2025
Closed
francisdb
francisdb reviewed Jan 11, 2025
View reviewed changes
README.md Outdated
### DIP Switches

PinMAME stores DIP Switch values in the last six bytes of the `.nv` file.
The first byte represents SW1 to SW8, with SW1 in bit 0. The second byte
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better to use least significant bit instead of bit 0. Not sure what the usual terms are for this.

@francisdb
Copy link
Contributor

Why are the _notes changes repeated in this pr? That was already merged?

@tomlogic
Copy link
Owner Author

Why are the _notes changes repeated in this pr? That was already merged?

I think because I did a partial merge, and GitHub just didn't update the PR to only include the three outstanding commits.

@tomlogic tomlogic merged commit d73b1a5 into master Jan 13, 2025
1 check passed
@tomlogic tomlogic deleted the feature/dipsw branch January 13, 2025 20:53
@francisdb francisdb mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francisdb francisdb francisdb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomlogic @francisdb