Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-string values? #83

Closed
francisdb opened this issue Jan 10, 2025 · 3 comments
Closed

Non-string values? #83

francisdb opened this issue Jan 10, 2025 · 3 comments

Comments

@francisdb
Copy link
Contributor

francisdb commented Jan 10, 2025

"values": [
1,
2,
4,
10,

The docs mention:

values: A list of strings used for the enum encoding, starting at index 0. Also used for the bits encoding, as values for bit 0, 1, 2, etc.

Should this be switched string or number?

@tomlogic
Copy link
Owner

I can clarify in the documentation that it's a list of integer values when used with bits. Do you think it's problematic to have two different data types depending on context? I'm also open to supporting both integers and strings in the list.

@francisdb
Copy link
Contributor Author

I don't think it has to be an issue if the docs mention it.

@tomlogic
Copy link
Owner

Resolved in #91.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants