Don't delete the build directory root #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since otherwise once Heroku builds are run from `/app`, builds will output warnings due to the `/app` root being read only: ``` remote: -----> Subdir buildpack app detected ... remote: cleaning build dir /app remote: rm: cannot remove '/app': Read-only file system ``` Fixes #9.
|
@timanovsky Hi! Sorry to ping you directly, but this buildpack is one of the most popular of the sub directory/monorepo style buildpacks on Heroku, so it would be great to get this merged to prevent user confusion once the build directory changes. Many thanks :-) |
This was referenced Mar 4, 2021
|
Thanks @edmorley for providing the patch. I have not been maintaining this code for some time. |
|
@timanovsky Thank you for merging :-) |
This was referenced Apr 1, 2021
|
Thank you for the patch :)
On Thu, 1 Apr 2021 at 16:00, Ed Morley ***@***.***> wrote:
@timanovsky <https://github.com/timanovsky> Thank you for merging :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJLIFSEMSXFEEIHTP3WU3TTGRU6BANCNFSM4YMPOSAA>
.
--
Best regards,
Alexey Timanovsky.
|
This was referenced Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since otherwise once Heroku builds are run from
/app, builds will output warnings due to the/approot being read only:Fixes #9.