Merge changes from upstream to fix "rm: cannot remove '/app': Read-only file system" #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since otherwise once Heroku builds are run from `/app`, builds will output warnings due to the `/app` root being read only: ``` remote: -----> Subdir buildpack app detected ... remote: cleaning build dir /app remote: rm: cannot remove '/app': Read-only file system ``` Fixes #9.
Don't delete the build directory root
|
1 year ping :-) |
|
Thanks a lot, @edmorley ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I'm on the team that maintains Heroku's build system and official buildpacks.
Very soon we are going to make a change to the Heroku build system that will mean builds using this buildpack emit warnings like:
A fix for these build log warnings has been merged into the upstream repository from which this one is forked:
timanovsky#10
This PR merges the changes from the upstream repository (which include that fix) back to this fork, so as to avoid these warnings in your builds in the future.
If you would like to avoid the merge commit from this PR (so that the two repository's Git histories do not diverge), then I'd recommend closing this PR as unmerged, and instead pulling upstream directly into
masterof this repo.For more information about the upcoming Heroku build system change and why this fix was needed, see:
timanovsky#9
I'm also happy to answer any questions you may have via discussion on this PR :-)