Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced Utility Functions - Remove duplicate code snippets #356

Merged
merged 15 commits into from
Feb 17, 2024

Conversation

Phelms215
Copy link
Contributor

Context

  • Introduced utility function for Logging, SteamCMD and Discord Messaging
  • Remove redundant (copy & paste) code snippets
  • Remove nesting where possible
  • Better Update/Install required logic
  • Removed requirement for UPDATE_ON_BOOT for initial installation

Choices

  • Clean up redundant code to make future enhancements easier to implement
  • Removed requirement for UPDATE_ON_BOOT if server installation is not detected (no PalServer.sh or appmanifest file)

Test instructions

  1. Started with old server version, ran through reboots with UPDATE_ON_BOOT and AUTOUPDATE flags set
  2. Started new server and validated installation
  3. Tested backup script
  4. Tested discord messaging
  5. Tested logging

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@Phelms215
Copy link
Contributor Author

This PR has been rebased onto the latest main to integrate recent changes.
Conflicts have been resolved.
Added command for rcon-cli

@win5923
Copy link
Contributor

win5923 commented Feb 12, 2024

I believe it's preferable to retain rcon-cli; otherwise, various adjustments will be required in the documentation.

@Phelms215
Copy link
Contributor Author

I believe it's preferable to retain rcon-cli; otherwise, various adjustments will be required in the documentation.

The change doesn't remove rcon-cli or adjust anything public, just provided a function wrapper so the config didn't need to be supplied a dozen times

@win5923
Copy link
Contributor

win5923 commented Feb 12, 2024

I believe it's preferable to retain rcon-cli; otherwise, various adjustments will be required in the documentation.

The change doesn't remove rcon-cli or adjust anything public, just provided a function wrapper so the config didn't need to be supplied a dozen times

You're right, I thought it was replacing rcon-cli with RCON. Thank you for clarifying!

@thijsvanloef
Copy link
Owner

@Phelms215 If you resolve the merge conflict, ready to merge!

@Phelms215 Phelms215 force-pushed the feature-utility-functions branch from 96693be to ce5e967 Compare February 17, 2024 04:06
@thijsvanloef thijsvanloef merged commit f709084 into thijsvanloef:main Feb 17, 2024
9 checks passed
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
…nctions

Introduced Utility Functions - Remove duplicate code snippets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants