Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Log/Message Handling #346

Closed
wants to merge 8 commits into from
Closed

Better Log/Message Handling #346

wants to merge 8 commits into from

Conversation

Phelms215
Copy link
Contributor

Context

Implement better log handling to reduce the amount of redundant code throughout script files and standardized how messages are recorded.

Choices

  • Migrated logging to functions within the helper_functions utility script. Allowing for easy use anywhere and a single point to modify the look & feel of messages

Test instructions

  1. Validate logging messages are being properly presented to the user

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@MSpreckels
Copy link
Contributor

Hey there!
this has the changes from #345 aswell. Is that on purpose?

@Phelms215 Phelms215 marked this pull request as draft February 10, 2024 09:35
@Phelms215
Copy link
Contributor Author

Nope - I'll sort out the git branch & request in the morning.
For now just put this into draft mode

@Phelms215
Copy link
Contributor Author

Closing in favor of #356

@Phelms215 Phelms215 closed this Feb 11, 2024
@Phelms215 Phelms215 deleted the log-functions branch February 18, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Phelms215 @MSpreckels