Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DoExit instead of Shutdown #395

Closed
Luatan opened this issue Feb 16, 2024 · 5 comments
Closed

Use DoExit instead of Shutdown #395

Luatan opened this issue Feb 16, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@Luatan
Copy link
Contributor

Luatan commented Feb 16, 2024

Is your feature request related to a problem? Please describe.
We are using the rcon shutdown command to stop the server. With this it always shows a message in game chat, that the server will shutdown in 1 second.

Describe the solution you'd like
Choose a command without output, and use the broadcast command to inform the players.

My suggestion would be to use the DoExit command instead. As far as I can tell it is the same just without the delay and message.

Describe alternatives you've considered
Keep the shutdown command as is.

What do you guys think?
@Luatan Luatan added the enhancement New feature or request label Feb 16, 2024
@Dashboy1998
Copy link
Contributor

My suggestion would be to use the DoExit command instead. As far as I can tell it is the same just without the delay and message.

When I first introduced the safe shutdown I was unsure if DoExit was a hard or soft termination so I went with shutdown. I'm not sure how to prove if DoExit is the same as shutdown with no timer.

@Luatan
Copy link
Contributor Author

Luatan commented Feb 16, 2024

My suggestion would be to use the DoExit command instead. As far as I can tell it is the same just without the delay and message.

When I first introduced the safe shutdown I was unsure if DoExit was a hard or soft termination so I went with shutdown. I'm not sure how to prove if DoExit is the same as shutdown with no timer.

I just tested both of them. They both trigger these log messages

palworld-server  | dlmopen steamservice.so failed: steamservice.so: cannot open shared object file: No such file or directory
palworld-server  | Shutdown handler: cleanup.

Because of this I would argue they do the same.

@Dashboy1998
Copy link
Contributor

My suggestion would be to use the DoExit command instead. As far as I can tell it is the same just without the delay and message.

When I first introduced the safe shutdown I was unsure if DoExit was a hard or soft termination so I went with shutdown. I'm not sure how to prove if DoExit is the same as shutdown with no timer.

I just tested both of them. They both trigger these log messages

palworld-server  | dlmopen steamservice.so failed: steamservice.so: cannot open shared object file: No such file or directory
palworld-server  | Shutdown handler: cleanup.

Because of this I would argue they do the same.

I tested using inotifywait -m -e modify,create,delete palworld/Pal/Saved to see the same files are edited with both commands.

Both edit all the INI files so I think it's safe to change it.

Setting up watches.  Beware: since -r was given, this may take a while!
Watches established.
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Compat.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Compat.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Paper2D.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Paper2D.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY ControlRig.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY ControlRig.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY LiveLink.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY LiveLink.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Composure.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Composure.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY ConcertSyncCore.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY ConcertSyncCore.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY EditorScriptingUtilities.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY EditorScriptingUtilities.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY EnhancedInput.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY EnhancedInput.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY DatasmithContent.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY DatasmithContent.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY GLTFExporter.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY GLTFExporter.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY VariantManagerContent.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY VariantManagerContent.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY CommonUI.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY CommonUI.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY FullBodyIK.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY FullBodyIK.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Niagara.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Niagara.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY MediaIOFramework.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY MediaIOFramework.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY ApexDestruction.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY ApexDestruction.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Metasound.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Metasound.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Synthesis.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Synthesis.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY CameraCalibrationCore.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY CameraCalibrationCore.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY LiveLinkCamera.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY LiveLinkCamera.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY ImGui.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY ImGui.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Wwise.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Wwise.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY PalWorldSettings.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY PalWorldSettings.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Engine.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Engine.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Game.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Game.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Input.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Input.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY DeviceProfiles.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY DeviceProfiles.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY GameUserSettings.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY GameUserSettings.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Scalability.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Scalability.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY RuntimeOptions.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY RuntimeOptions.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Hardware.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY Hardware.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY GameplayTags.ini
palworld/Pal/Saved/Config/LinuxServer/ MODIFY GameplayTags.ini
palworld/Pal/Saved/ImGui/ MODIFY Game.ini
palworld/Pal/Saved/ImGui/ MODIFY Game.ini

@Luatan
Copy link
Contributor Author

Luatan commented Feb 17, 2024

In that case I'll wait until #356 is merged and then create a PR for it.

@Dashboy1998 Dashboy1998 mentioned this issue Feb 17, 2024
Closed
3 tasks
Dashboy1998 added a commit to Dashboy1998/palworld-server-docker that referenced this issue Feb 17, 2024
@Dashboy1998
Changed shutdown to DoExit, resolves thijsvanloef#395
ca6b52f
This was referenced Feb 17, 2024
Closed
Merged
@Dashboy1998
Copy link
Contributor

This can be closed as it was implemented in #412

@Luatan Luatan closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dashboy1998 @Luatan