Make uv and nng private and static #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blozano-tt
changed the title
broskoTT
reviewed
Nov 22, 2024
broskoTT
approved these changes
Nov 22, 2024
joelsmithTT
approved these changes
Nov 22, 2024
afuller-TT
reviewed
Nov 22, 2024
afuller-TT
approved these changes
Nov 22, 2024
I am doing a quick test integration on metal side |
https://github.com/tenstorrent/tt-metal/actions/runs/11978804872 Things are looking good ... just one flaky test failure... |
broskoTT
added a commit
that referenced
this pull request
Nov 26, 2024
This reverts commit 0a41bf5. ### Issue No issue ### Description This change broke tt-metal build. post commit workflow failing: https://github.com/tenstorrent/tt-metal/actions/runs/12031721201 post commit workflow on this branch: https://github.com/tenstorrent/tt-metal/actions/runs/12032379476/job/33545486354 blackhole post-commit failing: https://github.com/tenstorrent/tt-metal/actions/runs/12031811999 blackhole post-commit on this branch: https://github.com/tenstorrent/tt-metal/actions/runs/12032509241 ### List of the changes - git revert 0a41bf5 ### Testing see description ### API Changes -
broskoTT
pushed a commit
that referenced
this pull request
Nov 27, 2024
broskoTT
added a commit
that referenced
this pull request
Dec 2, 2024
### Issue Original PR was #323, then the reverted one was #336 ### Description libnng.so is no longer a public dependency as of this PR: #224 Additionally, given that it is only consumed here it would be advantageous to statically link it. Why? So we don't have to: - Install it - Package it in a debian - Bundle it in a ttnn python wheel ... etc ... Along the above lines, I don't want to run into issues like this: ``` Traceback (most recent call last): File "/usr/lib/python3.8/runpy.py", line 185, in _run_module_as_main mod_name, mod_spec, code = _get_module_details(mod_name, _Error) File "/usr/lib/python3.8/runpy.py", line [11](https://github.com/tenstorrent/tt-metal/actions/runs/11964313949/job/33356936955#step:6:12)1, in _get_module_details __import__(pkg_name) File "/home/ubuntu/actions-runner/_work/tt-metal/tt-metal/tests/end_to_end_tests/env/lib/python3.8/site-packages/ttnn/__init__.py", line 20, in <module> import ttnn._ttnn ImportError: libnng.so.1: cannot open shared object file: No such file or directory ``` ### List of the changes Build nng as static Make it private linkage ### Testing Hoping CI is good enough ### API Changes There are no API changes in this PR. --------- Co-authored-by: Bryan Wilder Field Lozano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
NA
Description
libnng.so is no longer a public dependency as of this PR: #224
Additionally, given that it is only consumed here it would be advantageous to statically link it.
Why?
So we don't have to:
Along the above lines, I don't want to run into issues like this:
List of the changes
Build nng as static
Make it private linkage
Testing
Hoping CI is good enough
API Changes
There are no API changes in this PR.