Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uv and nng private and static (#323) #339

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Make uv and nng private and static (#323) #339

merged 4 commits into from
Dec 2, 2024

Conversation

broskoTT
Copy link
Contributor

@broskoTT broskoTT commented Nov 27, 2024

Issue

Original PR was #323, then the reverted one was #336

Description

libnng.so is no longer a public dependency as of this PR: #224
Additionally, given that it is only consumed here it would be advantageous to statically link it.
Why?
So we don't have to:

  • Install it
  • Package it in a debian
  • Bundle it in a ttnn python wheel ... etc ...

Along the above lines, I don't want to run into issues like this:

Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 185, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/usr/lib/python3.8/runpy.py", line [11](https://github.com/tenstorrent/tt-metal/actions/runs/11964313949/job/33356936955#step:6:12)1, in _get_module_details
    __import__(pkg_name)
  File "/home/ubuntu/actions-runner/_work/tt-metal/tt-metal/tests/end_to_end_tests/env/lib/python3.8/site-packages/ttnn/__init__.py", line 20, in <module>
    import ttnn._ttnn
ImportError: libnng.so.1: cannot open shared object file: No such file or directory

List of the changes

Build nng as static
Make it private linkage

Testing

Hoping CI is good enough

API Changes

There are no API changes in this PR.

@blozano-tt blozano-tt self-requested a review December 2, 2024 06:30
Copy link
Collaborator

@blozano-tt blozano-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@broskoTT broskoTT merged commit 7b9ea7d into main Dec 2, 2024
22 checks passed
@broskoTT broskoTT deleted the brosko/repeat branch December 2, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants