Make uv and nng private and static (#323) #339
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Original PR was #323, then the reverted one was #336
Description
libnng.so is no longer a public dependency as of this PR: #224
Additionally, given that it is only consumed here it would be advantageous to statically link it.
Why?
So we don't have to:
Along the above lines, I don't want to run into issues like this:
List of the changes
Build nng as static
Make it private linkage
Testing
Hoping CI is good enough
API Changes
There are no API changes in this PR.