Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uv and nng private and static #323

Merged
merged 6 commits into from
Nov 23, 2024
Merged

Make uv and nng private and static #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
38666bd
Make nng private and static
blozano-tt Nov 22, 2024
ed22179
Use fully qualified garget name, link nng::nng to tests
blozano-tt Nov 22, 2024
faf14d4
Don't Use fully qualified garget name
blozano-tt Nov 22, 2024
708c67f
Fix lint
blozano-tt Nov 22, 2024
d7200b7
Statically link uv
blozano-tt Nov 22, 2024
e457da5
Merge branch 'main' into blozano-make-nng-private-static
blozano-tt Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions cmake/dependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ function(fetch_dependencies)
GITHUB_REPOSITORY nanomsg/nng
GIT_TAG v1.8.0
OPTIONS
"BUILD_SHARED_LIBS ON"
"NNG_TESTS OFF"
"NNG_TOOLS OFF"
)
Expand Down Expand Up @@ -97,7 +96,14 @@ function(fetch_dependencies)
############################################################################################################################
# libuv (for process management)
############################################################################################################################
CPMAddPackage(NAME libuv GITHUB_REPOSITORY libuv/libuv GIT_TAG v1.48.0 OPTIONS "LIBUV_BUILD_TESTS OFF")
CPMAddPackage(
NAME libuv
GITHUB_REPOSITORY libuv/libuv
GIT_TAG v1.48.0
OPTIONS
"LIBUV_BUILD_TESTS OFF"
"LIBUV_BUILD_SHARED OFF"
)

############################################################################################################################
# fmt : https://github.com/fmtlib/fmt
Expand Down
5 changes: 2 additions & 3 deletions device/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,15 @@ target_include_directories(
)

# flatbuffers is public - exposed to tt_metal by tt_simulation_device_generated.h
# nng is public - exposed to tt_metal by tt_simulation_host.hpp
broskoTT marked this conversation as resolved.
Show resolved Hide resolved
target_link_libraries(
device
PUBLIC
nng
flatbuffers
uv
PRIVATE
blozano-tt marked this conversation as resolved.
Show resolved Hide resolved
hwloc
nng
rt
uv_a
Boost::interprocess
fmt::fmt-header-only
yaml-cpp::yaml-cpp
Expand Down
1 change: 1 addition & 0 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ target_link_libraries(
gtest
pthread
fmt::fmt-header-only
nng
)
target_include_directories(
test_common
Expand Down
Loading